Index: BUILD.gn |
diff --git a/BUILD.gn b/BUILD.gn |
index fc9b518c2e55d9a7bed8cc08bcee2727ac24e9f2..fc503c4e962d533fa8f262b85e5e89f108017674 100644 |
--- a/BUILD.gn |
+++ b/BUILD.gn |
@@ -73,32 +73,15 @@ config("icu_code") { |
"/wd4005", # Macro redefinition. |
"/wd4068", # Unknown pragmas. |
"/wd4267", # Conversion from size_t on 64-bits. |
- "/wd4996", # Deprecated functions. |
- # http://bugs.icu-project.org/trac/ticket/12821 |
jungshik at Google
2016/11/15 18:06:36
Did you mean to remove this comment? It's for wd43
brucedawson
2016/11/15 19:53:48
Good catch. I accidentally associated the comment
|
"/wd4333", # Right shift by too large amount. |
] |
} else if (is_linux || is_android) { |
cflags += [ |
- # Since ICU wants to internally use its own deprecated APIs, don't |
- # complain about it. |
- "-Wno-deprecated-declarations", |
"-Wno-unused-function", |
] |
} |
if (is_clang) { |
cflags += [ |
- # ICU uses its own deprecated functions. |
- "-Wno-deprecated-declarations", |
- # ICU prefers `a && b || c` over `(a && b) || c`. |
- "-Wno-logical-op-parentheses", |
- # ICU has some `unsigned < 0` checks. |
- "-Wno-tautological-compare", |
- # uresdata.c has switch(RES_GET_TYPE(x)) code. The |
- # RES_GET_TYPE macro returns an UResType enum, but some switch |
- # statement contains case values that aren't part of that |
- # enum (e.g. URES_TABLE32 which is in UResInternalType). This |
- # is on purpose. |
- "-Wno-switch", |
# ICU has some code with the pattern: |
# if (found = uprv_getWindowsTimeZoneInfo(...)) |
"-Wno-parentheses", |
@@ -107,15 +90,6 @@ config("icu_code") { |
# unistr.cpp also has an unused function for non-component builds. |
"-Wno-unused-function", |
] |
- if (is_win) { |
- cflags += [ |
- # See http://bugs.icu-project.org/trac/ticket/11122 |
- "-Wno-inline-new-delete", |
- "-Wno-implicit-exception-spec-mismatch", |
- # See http://www.icu-project.org/trac/ticket/11759. |
- "-Wno-unused-const-variable", |
- ] |
- } |
} |
} |