Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2492553003: [ignition] Fix -Wsign-compare warnings. (Closed)

Created:
4 years, 1 month ago by ulan
Modified:
4 years, 1 month ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ignition] Fix -Wsign-compare warnings. BUG=v8:5614 Committed: https://crrev.com/98e06c342e19446485e078b792fdaad4855915d1 Cr-Commit-Position: refs/heads/master@{#40886}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add todo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -22 lines) Patch
M src/interpreter/bytecode-register-optimizer.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M test/unittests/interpreter/bytecode-array-iterator-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/unittests/interpreter/bytecode-register-optimizer-unittest.cc View 8 chunks +22 lines, -12 lines 0 comments Download
M test/unittests/interpreter/constant-array-builder-unittest.cc View 6 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
ulan
ptal
4 years, 1 month ago (2016-11-09 18:50:30 UTC) #2
rmcilroy
LGTM, thanks https://codereview.chromium.org/2492553003/diff/1/src/interpreter/bytecode-register-optimizer.h File src/interpreter/bytecode-register-optimizer.h (right): https://codereview.chromium.org/2492553003/diff/1/src/interpreter/bytecode-register-optimizer.h#newcode140 src/interpreter/bytecode-register-optimizer.h:140: CHECK_NE(static_cast<size_t>(equivalence_id_), kInvalidEquivalenceId); Could you add a TODO ...
4 years, 1 month ago (2016-11-10 08:54:44 UTC) #3
ulan
https://codereview.chromium.org/2492553003/diff/1/src/interpreter/bytecode-register-optimizer.h File src/interpreter/bytecode-register-optimizer.h (right): https://codereview.chromium.org/2492553003/diff/1/src/interpreter/bytecode-register-optimizer.h#newcode140 src/interpreter/bytecode-register-optimizer.h:140: CHECK_NE(static_cast<size_t>(equivalence_id_), kInvalidEquivalenceId); On 2016/11/10 08:54:43, rmcilroy wrote: > Could ...
4 years, 1 month ago (2016-11-10 10:59:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492553003/20001
4 years, 1 month ago (2016-11-10 10:59:36 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-10 11:25:23 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:28:54 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/98e06c342e19446485e078b792fdaad4855915d1
Cr-Commit-Position: refs/heads/master@{#40886}

Powered by Google App Engine
This is Rietveld 408576698