Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Unified Diff: src/interpreter/bytecode-register-optimizer.h

Issue 2492553003: [ignition] Fix -Wsign-compare warnings. (Closed)
Patch Set: add todo Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/unittests/interpreter/bytecode-array-iterator-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/bytecode-register-optimizer.h
diff --git a/src/interpreter/bytecode-register-optimizer.h b/src/interpreter/bytecode-register-optimizer.h
index 885f10f3441e9159c5a6a24063d0de5480adfdcb..e2a02cf5948595391c338555430b40240df024ff 100644
--- a/src/interpreter/bytecode-register-optimizer.h
+++ b/src/interpreter/bytecode-register-optimizer.h
@@ -137,7 +137,8 @@ class V8_EXPORT_PRIVATE BytecodeRegisterOptimizer final
uint32_t NextEquivalenceId() {
equivalence_id_++;
- CHECK_NE(equivalence_id_, kInvalidEquivalenceId);
+ // TODO(rmcilroy): use the same type for these and remove static_cast.
+ CHECK_NE(static_cast<size_t>(equivalence_id_), kInvalidEquivalenceId);
return equivalence_id_;
}
« no previous file with comments | « no previous file | test/unittests/interpreter/bytecode-array-iterator-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698