Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issue 2492503002: Linux installer: Fix APT_SOURCES and APT_SOURCESDIR paths (Closed)

Created:
4 years, 1 month ago by Tom (Use chromium acct)
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang, Tom Anderson
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, Michael Moss, wfh+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Linux installer: Fix APT_SOURCES and APT_SOURCESDIR paths > In prior versions of Ubuntu/Debian the Dir::Etc apt-config variable > contained a trailing slash by default. The cronjob at > /etc/cron.daily/google-chrome was concatenating that variable into a > path, assuming the trailing slash. But in Ubuntu 16.10, the trailing > slash is gone. That breaks the path to the list file, and the cronjob > fails to fix it. > > BUG=663069 > > Review-Url: https://codereview.chromium.org/2482343002 > Cr-Commit-Position: refs/heads/master@{#430771} > BUG=663069 TBR=thestig@chromium.org NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/installer/linux/common/apt.include View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Tom Anderson
lgtm
4 years, 1 month ago (2016-11-09 17:32:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492503002/1
4 years, 1 month ago (2016-11-09 17:32:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 17:36:41 UTC) #8
Lei Zhang
lgtm, no need to approve your own CLs...
4 years, 1 month ago (2016-11-09 17:39:36 UTC) #9
Tom (Use chromium acct)
4 years, 1 month ago (2016-11-09 17:41:08 UTC) #10
Message was sent while issue was closed.
On 2016/11/09 17:39:36, Lei Zhang (slow) wrote:
> lgtm, no need to approve your own CLs...

I wouldn't be able to upload it from my @google account without approval from my
@chromium account.  I always forget to just upload from the right account :S.  I
think it's finally time to change my git config while I don't have that many
open CLs

Powered by Google App Engine
This is Rietveld 408576698