Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2482343002:
Linux installer: Fix APT_SOURCES and APT_SOURCESDIR paths (Closed)
|
Created:
4 years, 1 month ago by Tom (Use chromium acct) Modified:
4 years, 1 month ago Reviewers:
Lei Zhang CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, Michael Moss, wfh+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionLinux installer: Fix APT_SOURCES and APT_SOURCESDIR paths
In prior versions of Ubuntu/Debian the Dir::Etc apt-config variable contained a trailing slash by default. The cronjob at /etc/cron.daily/google-chrome was concatenating that variable into a path, assuming the trailing slash. But in Ubuntu 16.10, the trailing slash is gone. That breaks the path to the list file, and the cronjob fails to fix it.
BUG=663069
Committed: https://crrev.com/389af6af989c5ba5384988b55fc28a3f231a1479
Cr-Commit-Position: refs/heads/master@{#430771}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 16 (9 generated)
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Linux installer: Fix APT_SOURCES and APT_SOURCESDIR paths BUG=663069 ========== to ========== Linux installer: Fix APT_SOURCES and APT_SOURCESDIR paths In prior versions of Ubuntu/Debian the Dir::Etc apt-config variable contained a trailing slash by default. The cronjob at /etc/cron.daily/google-chrome was concatenating that variable into a path, assuming the trailing slash. But in Ubuntu 16.10, the trailing slash is gone. That breaks the path to the list file, and the cronjob fails to fix it. BUG=663069 ==========
thomasanderson@google.com changed reviewers: + thestig@chromium.org
thestig@ PTAL Users that have any channel of Chrome installed on Ubuntu 16.10 (or Debian testing) are now permanently unable to upgrade, and are stranded there until they reinstall a newer version of chrome :(
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2482343002/diff/1/chrome/installer/linux/comm... File chrome/installer/linux/common/apt.include (right): https://codereview.chromium.org/2482343002/diff/1/chrome/installer/linux/comm... chrome/installer/linux/common/apt.include:147: # though that sometimes gives a double slash. Does "${APTDIR%/}/" make it consistently 1 slash?
On 2016/11/08 23:44:35, Lei Zhang (slow) wrote: > lgtm > > https://codereview.chromium.org/2482343002/diff/1/chrome/installer/linux/comm... > File chrome/installer/linux/common/apt.include (right): > > https://codereview.chromium.org/2482343002/diff/1/chrome/installer/linux/comm... > chrome/installer/linux/common/apt.include:147: # though that sometimes gives a > double slash. > Does "${APTDIR%/}/" make it consistently 1 slash? Yes, but it shouldn't really matter if there's 2 slashes, right?
The CQ bit was checked by thomasanderson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/11/08 23:46:08, Tom Anderson wrote: > Yes, but it shouldn't really matter if there's 2 slashes, right? It doesn't matter.
Message was sent while issue was closed.
Description was changed from ========== Linux installer: Fix APT_SOURCES and APT_SOURCESDIR paths In prior versions of Ubuntu/Debian the Dir::Etc apt-config variable contained a trailing slash by default. The cronjob at /etc/cron.daily/google-chrome was concatenating that variable into a path, assuming the trailing slash. But in Ubuntu 16.10, the trailing slash is gone. That breaks the path to the list file, and the cronjob fails to fix it. BUG=663069 ========== to ========== Linux installer: Fix APT_SOURCES and APT_SOURCESDIR paths In prior versions of Ubuntu/Debian the Dir::Etc apt-config variable contained a trailing slash by default. The cronjob at /etc/cron.daily/google-chrome was concatenating that variable into a path, assuming the trailing slash. But in Ubuntu 16.10, the trailing slash is gone. That breaks the path to the list file, and the cronjob fails to fix it. BUG=663069 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Linux installer: Fix APT_SOURCES and APT_SOURCESDIR paths In prior versions of Ubuntu/Debian the Dir::Etc apt-config variable contained a trailing slash by default. The cronjob at /etc/cron.daily/google-chrome was concatenating that variable into a path, assuming the trailing slash. But in Ubuntu 16.10, the trailing slash is gone. That breaks the path to the list file, and the cronjob fails to fix it. BUG=663069 ========== to ========== Linux installer: Fix APT_SOURCES and APT_SOURCESDIR paths In prior versions of Ubuntu/Debian the Dir::Etc apt-config variable contained a trailing slash by default. The cronjob at /etc/cron.daily/google-chrome was concatenating that variable into a path, assuming the trailing slash. But in Ubuntu 16.10, the trailing slash is gone. That breaks the path to the list file, and the cronjob fails to fix it. BUG=663069 Committed: https://crrev.com/389af6af989c5ba5384988b55fc28a3f231a1479 Cr-Commit-Position: refs/heads/master@{#430771} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/389af6af989c5ba5384988b55fc28a3f231a1479 Cr-Commit-Position: refs/heads/master@{#430771} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
