Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1862)

Unified Diff: build/config/mac/rules.gni

Issue 2492493002: [Mac/GN] Don't list any symlinks in the outputs of mac_framework_bundle. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/mac/rules.gni
diff --git a/build/config/mac/rules.gni b/build/config/mac/rules.gni
index 018ab49e294bd32ee6167d5778d6b0ad9f953cae..f59503481f8fdc4c4000e12c53b5e322285da858 100644
--- a/build/config/mac/rules.gni
+++ b/build/config/mac/rules.gni
@@ -328,17 +328,13 @@ template("mac_framework_bundle") {
]
if (defined(invoker.framework_version)) {
- outputs += [ "$_framework_base_dir/Versions/Current" ]
args += [
"--version",
invoker.framework_version,
"--contents",
] + _framework_contents
-
# It is not possible to list _framework_contents as outputs, since
- # ninja does not properly stat symbolic links. The exception is the
- # "Current" symlink, since package_framework.py will ensure that
- # directory exists so the resolved-symlink mtime will be up-to-date.
+ # ninja does not properly stat symbolic links.
# https://github.com/ninja-build/ninja/issues/1186
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698