Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: build/config/mac/rules.gni

Issue 2492493002: [Mac/GN] Don't list any symlinks in the outputs of mac_framework_bundle. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/mac/base_rules.gni") 5 import("//build/config/mac/base_rules.gni")
6 6
7 # Generates Info.plist files for Mac apps and frameworks. 7 # Generates Info.plist files for Mac apps and frameworks.
8 # 8 #
9 # Arguments 9 # Arguments
10 # 10 #
(...skipping 310 matching lines...) Expand 10 before | Expand all | Expand 10 after
321 visibility = [ ":$_framework_target" ] 321 visibility = [ ":$_framework_target" ]
322 322
323 args = [ 323 args = [
324 "--framework", 324 "--framework",
325 rebase_path(_framework_base_dir, root_build_dir), 325 rebase_path(_framework_base_dir, root_build_dir),
326 "--stamp", 326 "--stamp",
327 rebase_path(_stamp_file, root_build_dir), 327 rebase_path(_stamp_file, root_build_dir),
328 ] 328 ]
329 329
330 if (defined(invoker.framework_version)) { 330 if (defined(invoker.framework_version)) {
331 outputs += [ "$_framework_base_dir/Versions/Current" ]
332 args += [ 331 args += [
333 "--version", 332 "--version",
334 invoker.framework_version, 333 invoker.framework_version,
335 "--contents", 334 "--contents",
336 ] + _framework_contents 335 ] + _framework_contents
337
338 # It is not possible to list _framework_contents as outputs, since 336 # It is not possible to list _framework_contents as outputs, since
339 # ninja does not properly stat symbolic links. The exception is the 337 # ninja does not properly stat symbolic links.
340 # "Current" symlink, since package_framework.py will ensure that
341 # directory exists so the resolved-symlink mtime will be up-to-date.
342 # https://github.com/ninja-build/ninja/issues/1186 338 # https://github.com/ninja-build/ninja/issues/1186
343 } 339 }
344 } 340 }
345 341
346 _link_shared_library_target = target_name + "_shared_library" 342 _link_shared_library_target = target_name + "_shared_library"
347 _shared_library_bundle_data = target_name + "_shared_library_bundle_data" 343 _shared_library_bundle_data = target_name + "_shared_library_bundle_data"
348 344
349 shared_library(_link_shared_library_target) { 345 shared_library(_link_shared_library_target) {
350 forward_variables_from(invoker, 346 forward_variables_from(invoker,
351 "*", 347 "*",
(...skipping 334 matching lines...) Expand 10 before | Expand all | Expand 10 after
686 ]) 682 ])
687 if (!defined(deps)) { 683 if (!defined(deps)) {
688 deps = [] 684 deps = []
689 } 685 }
690 deps += [ ":$_loadable_module_bundle_data" ] 686 deps += [ ":$_loadable_module_bundle_data" ]
691 687
692 bundle_root_dir = "$root_out_dir/$_output_name.plugin/Contents" 688 bundle_root_dir = "$root_out_dir/$_output_name.plugin/Contents"
693 bundle_executable_dir = "$bundle_root_dir/MacOS" 689 bundle_executable_dir = "$bundle_root_dir/MacOS"
694 } 690 }
695 } 691 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698