Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2492493002: [Mac/GN] Don't list any symlinks in the outputs of mac_framework_bundle. (Closed)

Created:
4 years, 1 month ago by Robert Sesek
Modified:
4 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/GN] Don't list any symlinks in the outputs of mac_framework_bundle. Despite the comment left in 9522ddcc745f, the bots do not agree that this is stable. BUG=648757 Committed: https://crrev.com/7accb69c5cc3c08b6c36b2d616cf4a38892ade55 Cr-Commit-Position: refs/heads/master@{#431098}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M build/config/mac/rules.gni View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Robert Sesek
I think I didn't catch this because it only repros if you don't explicitly build ...
4 years, 1 month ago (2016-11-09 18:09:39 UTC) #3
Robert Sesek
Please cq if lg.
4 years, 1 month ago (2016-11-09 23:48:06 UTC) #8
Dirk Pranke
lgtm
4 years, 1 month ago (2016-11-10 00:23:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492493002/1
4 years, 1 month ago (2016-11-10 00:24:11 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 00:30:29 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 00:38:21 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7accb69c5cc3c08b6c36b2d616cf4a38892ade55
Cr-Commit-Position: refs/heads/master@{#431098}

Powered by Google App Engine
This is Rietveld 408576698