Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 2492463005: Mojo C++ bindings: reduce references to AssociatedGroupController. (Closed)

Created:
4 years, 1 month ago by yzshen1
Modified:
4 years, 1 month ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: reduce references to AssociatedGroupController. If an interface doesn't pass associated kinds, there is no need to store a ref to AssociatedGroupController in the serialization context. That shouldn't have any effect on the interface pointer side, because all those references will be cleared when pipe disconnection happens or the interface pointer is destroyed. However on the binding side, if we don't do this, as long as someone holds on the any method callback given to the impl, the AssociatedGroupController will be kept alive. BUG=651103 Committed: https://crrev.com/3fa6ea22828a127d5ee91afe01553531f0932880 Cr-Commit-Position: refs/heads/master@{#431353}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M mojo/public/cpp/bindings/associated_binding.h View 1 1 chunk +4 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/lib/associated_interface_ptr_state.h View 1 1 chunk +4 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/lib/binding_state.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/interface_ptr_state.h View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
yzshen1
Hi, Ken. This is a speculative improvement for the memory regression on Android One. I ...
4 years, 1 month ago (2016-11-10 19:58:20 UTC) #6
Ken Rockot(use gerrit already)
lgtm
4 years, 1 month ago (2016-11-10 20:05:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492463005/20001
4 years, 1 month ago (2016-11-10 20:06:39 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-10 21:14:39 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 21:23:39 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3fa6ea22828a127d5ee91afe01553531f0932880
Cr-Commit-Position: refs/heads/master@{#431353}

Powered by Google App Engine
This is Rietveld 408576698