mojo/public/cpp/bindings/lib/binding_state.h - Issue 2492463005: Mojo C++ bindings: reduce references to AssociatedGroupController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/lib/binding_state.h

Issue 2492463005: Mojo C++ bindings: reduce references to AssociatedGroupController. (Closed)

Patch Set: . Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/cpp/bindings/lib/binding_state.h

diff --git a/mojo/public/cpp/bindings/lib/binding_state.h b/mojo/public/cpp/bindings/lib/binding_state.h

index 1842509288c24d6fcd40f0b44a47fe1dc53cf325..a947cf73c57c9d13b7a80370b33983e8c197863c 100644

--- a/mojo/public/cpp/bindings/lib/binding_state.h

+++ b/mojo/public/cpp/bindings/lib/binding_state.h

@@ -216,7 +216,8 @@ class BindingState<Interface, true, ImplRefTraits>

base::MakeUnique<typename Interface::RequestValidator_>(),

Interface::PassesAssociatedKinds_, Interface::HasSyncMethods_, &stub_,

Interface::Version_);

- stub_.serialization_context()->group_controller = router_;

+ if (Interface::PassesAssociatedKinds_)

+ stub_.serialization_context()->group_controller = router_;

}

InterfaceRequest<Interface> Unbind() {