[Payments] Allow for editing of local cards, addresses and contacts (add pencil icon)

chrome/android/java/res/layout/payment_option_edit_icon.xml

Index: chrome/android/java/res/layout/payment_option_edit_icon.xml
diff --git a/chrome/android/java/res/layout/payment_option_edit_icon.xml b/chrome/android/java/res/layout/payment_option_edit_icon.xml
new file mode 100644
index 0000000000000000000000000000000000000000..aad5ae24bbd692a10999a28683c8624b424f7936
--- /dev/null
+++ b/chrome/android/java/res/layout/payment_option_edit_icon.xml
@@ -0,0 +1,25 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2016 The Chromium Authors. All rights reserved.
+     Use of this source code is governed by a BSD-style license that can be
+     found in the LICENSE file. -->
+     
+<LinearLayout
+	xmlns:android="http://schemas.android.com/apk/res/android"
+	android:layout_width="wrap_content"
+	android:layout_height="wrap_content">
+
+	<View

[gone, 2016/11/15 01:19:43]

Indent 8 for attributes and 4 for children XML tags.  Been seeing that more
lately and it makes the layout easier to parse.

[gogerald1, 2016/11/15 16:43:39]

Done. Curious, how this indentation makes it easier to parse?

[gone, 2016/11/15 18:07:14]

You can tell where children actually start and what belongs to the previous
line.  You do the same thing in Java and C++.

+		android:layout_width="1dp"
+		android:layout_height="48dp"
+		android:layout_gravity="center_vertical"
+		android:layout_marginStart="@dimen/payments_section_large_spacing"
+		android:layout_marginEnd="@dimen/payments_section_large_spacing"
+		android:background="@color/payments_section_separator"/>

[please use gerrit instead, 2016/11/14 21:51:41]

Please mark this importantForAccessibility="no", so the screen reader ignores
it.

[gogerald1, 2016/11/15 16:43:39]

Done.

+
+	<ImageView
+		android:layout_width="24dp"
+		android:layout_height="24dp"
+		android:layout_gravity="center_vertical"
+		android:src="@drawable/bookmark_edit_normal"
+		android:contentDescription="@null" />

[please use gerrit instead, 2016/11/14 21:51:41]

Please add a description for accessibility.

[gogerald1, 2016/11/15 16:43:39]

Have set content description for the parent linearlayout. Move it in to this
file for clearance since this xml is only been used as edit button.

+</LinearLayout>