chrome/android/java/res/layout/payment_option_edit_icon.xml - Issue 2492243002: [Payments] Allow for editing of local cards, addresses and contacts (add pencil icon)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/payment_option_edit_icon.xml

Issue 2492243002: [Payments] Allow for editing of local cards, addresses and contacts (add pencil icon) (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <LinearLayout

	7 xmlns:android="http://schemas.android.com/apk/res/android"

	8 android:layout_width="wrap_content"

	9 android:layout_height="wrap_content">

	10

	11 <View
	gone 2016/11/15 01:19:43 Indent 8 for attributes and 4 for children XML tag Indent 8 for attributes and 4 for children XML tags. Been seeing that more lately and it makes the layout easier to parse. gogerald1 2016/11/15 16:43:39 Done. Curious, how this indentation makes it easie Show quoted text On 2016/11/15 01:19:43, dfalcantara (check my queue) wrote: > Indent 8 for attributes and 4 for children XML tags. Been seeing that more > lately and it makes the layout easier to parse. Done. Curious, how this indentation makes it easier to parse? gone 2016/11/15 18:07:14 You can tell where children actually start and wha Show quoted text On 2016/11/15 16:43:39, gogerald1 wrote: > On 2016/11/15 01:19:43, dfalcantara (check my queue) wrote: > > Indent 8 for attributes and 4 for children XML tags. Been seeing that more > > lately and it makes the layout easier to parse. > > Done. Curious, how this indentation makes it easier to parse? You can tell where children actually start and what belongs to the previous line. You do the same thing in Java and C++.
	12 android:layout_width="1dp"

	13 android:layout_height="48dp"

	14 android:layout_gravity="center_vertical"

	15 android:layout_marginStart="@dimen/payments_section_large_spacin g"

	16 android:layout_marginEnd="@dimen/payments_section_large_spacing"

	17 android:background="@color/payments_section_separator"/>
	please use gerrit instead 2016/11/14 21:51:41 Please mark this importantForAccessibility="no", s Please mark this importantForAccessibility="no", so the screen reader ignores it. gogerald1 2016/11/15 16:43:39 Done. Show quoted text On 2016/11/14 21:51:41, rouslan wrote: > Please mark this importantForAccessibility="no", so the screen reader ignores > it. Done.
	18

	19 <ImageView

	20 android:layout_width="24dp"

	21 android:layout_height="24dp"

	22 android:layout_gravity="center_vertical"

	23 android:src="@drawable/bookmark_edit_normal"

	24 android:contentDescription="@null" />
	please use gerrit instead 2016/11/14 21:51:41 Please add a description for accessibility. Please add a description for accessibility. gogerald1 2016/11/15 16:43:39 Have set content description for the parent linear Show quoted text On 2016/11/14 21:51:41, rouslan wrote: > Please add a description for accessibility. Have set content description for the parent linearlayout. Move it in to this file for clearance since this xml is only been used as edit button.
	25 </LinearLayout>

OLD	NEW