[DevTools] reworked JavaScriptBreakpointsSidebarPane.js

third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints.html

Index: third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints.html b/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints.html
index 13157894490b4dac27f77ddda556baae17186abf..4a1d69650f0028b08e5ae0530148f2f911fc65be 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints.html
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints.html
@@ -28,8 +28,7 @@ function test()
             function onSourceFrame(sourceFrame)
             {
                 InspectorTest.setBreakpoint(sourceFrame, 0, "", true);
-                dumpBreakpointSidebarPane();
-                next();
+                InspectorTest.waitBreakpointSidebarPane().then(InspectorTest.dumpBreakpointSidebarPane).then(next);
             }
         },
 
@@ -40,8 +39,7 @@ function test()
 
             function onBindingCreated(binding)
             {
-                dumpBreakpointSidebarPane();
-                next();
+                InspectorTest.waitBreakpointSidebarPane().then(InspectorTest.dumpBreakpointSidebarPane).then(next);
             }
         },
 
@@ -56,19 +54,10 @@ function test()
                 if (binding.network.name() !== "foo.js")
                     return
                 Persistence.persistence.removeEventListener(Persistence.Persistence.Events.BindingRemoved, onBindingRemoved);
-                dumpBreakpointSidebarPane();
-                next();
+                InspectorTest.waitBreakpointSidebarPane().then(InspectorTest.dumpBreakpointSidebarPane).then(next);
             }
         },
     ]);
-
-    function dumpBreakpointSidebarPane()
-    {
-        var sidebarPane = self.runtime.sharedInstance(Sources.JavaScriptBreakpointsSidebarPane)

[lushnikov, 2016/11/14 18:56:15]

can we retain this using your approach from JSSP?

var node = event.target.enclosingNodeOrSelfWithClass('breakpoint-entry');

[kozy, 2016/11/14 19:45:25]

Done.

-        var breakpoints = sidebarPane._items.keysArray();
-        for (var breakpoint of breakpoints)
-            InspectorTest.addResult("    " + breakpoint.uiSourceCode().url() +":" + breakpoint.lineNumber());
-    }
 };
 </script>
 </head>