[DevTools] reworked JavaScriptBreakpointsSidebarPane.js

third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js

Index: third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js
index 405a79ff54fade9e87ad85ce9d300732d3618eb8..05b1e612a0f4c404870e28dbd14a6650bd0a0ef4 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js
@@ -425,11 +425,25 @@ InspectorTest.removeBreakpoint = function(sourceFrame, lineNumber)
     sourceFrame._breakpointManager.findBreakpoints(sourceFrame._uiSourceCode, lineNumber)[0].remove();
 };
 
+InspectorTest.waitBreakpointSidebarPane = function()

[lushnikov, 2016/11/14 18:56:15]

nit: you can avoid exposing breakpointsSidebarPaneContent via adding a flag to
the waitBreakpointsSIdebarPane:

... = function(nonEmpty) {

  ... 
}

[kozy, 2016/11/14 19:45:25]

Acknowledged.

+{
+    return new Promise(resolve => InspectorTest.addSniffer(Sources.JavaScriptBreakpointsSidebarPane.prototype, "didUpdateForTest", resolve));
+}
+
+InspectorTest.breakpointsSidebarPaneContent = function()
+{
+    var paneElement = self.runtime.sharedInstance(Sources.JavaScriptBreakpointsSidebarPane).contentElement;
+    var empty = paneElement.querySelector('.gray-info-message');
+    if (empty)
+        return InspectorTest.textContentWithLineBreaks(empty);
+    var entries = Array.from(paneElement.querySelectorAll('.breakpoint-entry'));
+    return entries.map(InspectorTest.textContentWithLineBreaks).join('\n');
+}
+
 InspectorTest.dumpBreakpointSidebarPane = function(title)
 {
-    var paneElement = self.runtime.sharedInstance(Sources.JavaScriptBreakpointsSidebarPane).element;
     InspectorTest.addResult("Breakpoint sidebar pane " + (title || ""));
-    InspectorTest.addResult(InspectorTest.textContentWithLineBreaks(paneElement));
+    InspectorTest.addResult(InspectorTest.breakpointsSidebarPaneContent());
 };
 
 InspectorTest.dumpScopeVariablesSidebarPane = function()