Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2491943003: Revert "Fix bug: turns on BIND_EXTERNAL_SERVICE flag on Android N crashes WebAPK." (1/3) (Closed)

Created:
4 years, 1 month ago by Xi Han
Modified:
4 years, 1 month ago
Reviewers:
michaelbai, boliu, agrieve
CC:
chromium-reviews, jam, darin-cc_chromium.org, agrieve+watch_chromium.org, Torne, pkotwicz
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Fix bug: turns on BIND_EXTERNAL_SERVICE flag on Android N crashes WebAPK." This reverts commit 70041c05e3ea17a1e67d0b2b1afb3929faf06e0d because it doesn't really fix the crash of WebAPK, and a better solution will be in a follow up CL. BUG=663898, 663888 Committed: https://crrev.com/f828e12850d8d3a71529ea4aa66660ff149576a6 Cr-Commit-Position: refs/heads/master@{#431370}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java View 4 chunks +3 lines, -12 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Xi Han
Hi Michael, Bo and Andrew: I revert 3 CLs in the following orders: https://codereview.chromium.org/2488963004/ https://codereview.chromium.org/2464143004 ...
4 years, 1 month ago (2016-11-10 19:47:26 UTC) #4
boliu
lgtm
4 years, 1 month ago (2016-11-10 21:32:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491943003/1
4 years, 1 month ago (2016-11-10 21:49:43 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 21:54:44 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 23:10:01 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f828e12850d8d3a71529ea4aa66660ff149576a6
Cr-Commit-Position: refs/heads/master@{#431370}

Powered by Google App Engine
This is Rietveld 408576698