Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: ppapi/api/private/ppb_nacl_private.idl

Issue 249183004: Implement open_resource in non-SFI mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/api/private/ppb_nacl_private.idl
diff --git a/ppapi/api/private/ppb_nacl_private.idl b/ppapi/api/private/ppb_nacl_private.idl
index 4bc02e0749e7c182c9b3ed4decbac5cb70359387..a427920ef9b144b99f782e9cd196ef8dee5d8545 100644
--- a/ppapi/api/private/ppb_nacl_private.idl
+++ b/ppapi/api/private/ppb_nacl_private.idl
@@ -146,12 +146,20 @@ struct PP_PNaClOptions {
* Once false is called, as the service has been destructed, all functions
* should never be called afterwords.
*/
-interface PP_ManifestService {
+interface PPB_ManifestService {
teravest 2014/04/24 20:00:52 nit: I'd prefer that this stay as PP_ManifestServi
hidehiko 2014/04/25 05:53:54 PPKind.ChoosePPFunc in idl_gen_wrapper.py doesn't
/* Called when ManifestService should be destructed. */
PP_Bool Quit([inout] mem_t user_data);
/* Called when PPAPI initialization in the NaCl plugin is finished. */
PP_Bool StartupInitializationComplete([inout] mem_t user_data);
+
+ /* Called when irt_open_resource() is invoked in the NaCl plugin.
+ * Upon completion, callback will be invoked. If the OpenResource() returns
+ * PP_FALSE, callback will never be called. */
+ PP_Bool OpenResource([inout] mem_t user_data,
+ [in] str_t entry_key,
+ [out] PP_FileHandle file,
+ [in] PP_CompletionCallback callback);
};
/* PPB_NaCl_Private */
@@ -184,7 +192,7 @@ interface PPB_NaCl_Private {
[in] PP_Bool enable_dyncode_syscalls,
[in] PP_Bool enable_exception_handling,
[in] PP_Bool enable_crash_throttling,
- [in] PP_ManifestService manifest_service_interface,
+ [in] PPB_ManifestService manifest_service_interface,
[inout] mem_t manifest_service_user_data,
[out] mem_t imc_handle,
[out] PP_Var error_message,

Powered by Google App Engine
This is Rietveld 408576698