Implement open_resource in non-SFI mode.

ppapi/api/private/ppb_nacl_private.idl

 /* Copyright (c) 2012 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /* This file contains NaCl private interfaces. This interface is not versioned
  * and is for internal Chrome use. It may change without notice. */
 
 label Chrome {
   M25 = 1.0
@@ skipping 128 matching lines @@
   int32_t opt_level;
 };
 
 /* ManifestService to support irt_open_resource() function.
  * All functions of the service should have PP_Bool return value. It represents
  * whether the service is still alive or not. Trivially Quit() should always
  * return false. However, other functions also can return false.
  * Once false is called, as the service has been destructed, all functions
  * should never be called afterwords.
  */
-interface PP_ManifestService {
+interface PPB_ManifestService {

[teravest, 2014/04/24 20:00:52]

nit: I'd prefer that this stay as PP_ManifestService.

PPB_ManifestService suggests that the plugin is sending methods to the browser
to do work, but this is more like what a PPP_ interface would be. I think just
leaving the PP_ prefix is fine, though.

[hidehiko, 2014/04/25 05:53:54]

PPKind.ChoosePPFunc in idl_gen_wrapper.py doesn't work with PP_. So, let's use
PPP_ instead, then.

   /* Called when ManifestService should be destructed. */
   PP_Bool Quit([inout] mem_t user_data);
 
   /* Called when PPAPI initialization in the NaCl plugin is finished. */
   PP_Bool StartupInitializationComplete([inout] mem_t user_data);
+
+  /* Called when irt_open_resource() is invoked in the NaCl plugin.
+   * Upon completion, callback will be invoked. If the OpenResource() returns
+   * PP_FALSE, callback will never be called. */
+  PP_Bool OpenResource([inout] mem_t user_data,
+                       [in] str_t entry_key,
+                       [out] PP_FileHandle file,
+                       [in] PP_CompletionCallback callback);
 };
 
 /* PPB_NaCl_Private */
 interface PPB_NaCl_Private {
   /* Launches NaCl's sel_ldr process.  Returns PP_EXTERNAL_PLUGIN_OK on success
    * and writes a NaClHandle to imc_handle. Returns PP_EXTERNAL_PLUGIN_FAILED on
    * failure. The |enable_ppapi_dev| parameter controls whether GetInterface
    * returns 'Dev' interfaces to the NaCl plugin.  The |uses_ppapi| flag
    * indicates that the nexe run by sel_ldr will use the PPAPI APIs.
    * This implies that LaunchSelLdr is run from the main thread.  If a nexe
@@ skipping 12 matching lines @@
    */
   void LaunchSelLdr([in] PP_Instance instance,
                     [in] str_t alleged_url,
                     [in] PP_Bool uses_irt,
                     [in] PP_Bool uses_ppapi,
                     [in] PP_Bool uses_nonsfi_mode,
                     [in] PP_Bool enable_ppapi_dev,
                     [in] PP_Bool enable_dyncode_syscalls,
                     [in] PP_Bool enable_exception_handling,
                     [in] PP_Bool enable_crash_throttling,
-                    [in] PP_ManifestService manifest_service_interface,
+                    [in] PPB_ManifestService manifest_service_interface,
                     [inout] mem_t manifest_service_user_data,
                     [out] mem_t imc_handle,
                     [out] PP_Var error_message,
                     [in] PP_CompletionCallback callback);
 
   /* This function starts the IPC proxy so the nexe can communicate with the
    * browser.
    */
   PP_Bool StartPpapiProxy(PP_Instance instance);
 
@@ skipping 181 matching lines @@
 
   PP_Var ParseDataURL([in] str_t data_url);
 
   /* Processes the NaCl manifest once it's been retrieved.
    * TODO(teravest): Move the rest of the supporting logic out of the trusted
    * plugin.
    */
   void ProcessNaClManifest([in] PP_Instance instance,
                            [in] str_t program_url);
 };