Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 2491803002: Revert "Adding UMA to track previews opt outs and blacklist eligibility" (Closed)

Created:
4 years, 1 month ago by Dirk Pranke
Modified:
4 years, 1 month ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Adding UMA to track previews opt outs and blacklist eligibility" > Adding UMA to track previews opt outs and blacklist eligibility > > This CL adds UMA to track the reason that a user was not shown a preview > (or if it was allowed) and whether a user opts out when shown a preview. > > BUG=647717 > Committed: https://crrev.com/cc61592651c3018a146387f691bc4cbd60f7807b > Cr-Commit-Position: refs/heads/master@{#431020} BUG=663940, 647717 TBR=ryansturm@chromium.org,asvitikine@chromium.org NOPRESUBMIT=true NOTRY=true Committed: https://crrev.com/032b6e1db3c05363d2db3d2323573ff3fad3512a Cr-Commit-Position: refs/heads/master@{#431091}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -409 lines) Patch
M components/previews/core/BUILD.gn View 2 chunks +1 line, -3 lines 0 comments Download
M components/previews/core/previews_black_list.h View 2 chunks +3 lines, -26 lines 0 comments Download
M components/previews/core/previews_black_list.cc View 3 chunks +6 lines, -17 lines 0 comments Download
M components/previews/core/previews_black_list_unittest.cc View 10 chunks +63 lines, -142 lines 0 comments Download
M components/previews/core/previews_io_data.cc View 3 chunks +8 lines, -41 lines 0 comments Download
M components/previews/core/previews_io_data_unittest.cc View 3 chunks +4 lines, -146 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 4 chunks +0 lines, -34 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491803002/1
4 years, 1 month ago (2016-11-10 00:15:47 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 00:16:57 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 00:28:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/032b6e1db3c05363d2db3d2323573ff3fad3512a
Cr-Commit-Position: refs/heads/master@{#431091}

Powered by Google App Engine
This is Rietveld 408576698