Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2491773007:
[Chromoting] Build break after change 2494013003 (Closed)
Description[Chromoting] Build break after change 2494013003
One reference to the deprecated screen_capturer_mock_objects.h has been missed
from change https://codereview.chromium.org/2494013003/.
BUG=webrtc:6513
TBR=sergeyu@chromium.org
Committed: https://crrev.com/38129a5549cd31ab14c5d7a970c0019a66f8bc40
Cr-Commit-Position: refs/heads/master@{#431758}
Patch Set 1 #
Messages
Total messages: 25 (16 generated)
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Build break One reference to the deprecated screen_capturer_mock_objects.h has been missed from last change. BUG=webrtc:6513 ========== to ========== [Chromoting] Build break after change 2494013003 One reference to the deprecated screen_capturer_mock_objects.h has been missed from change https://codereview.chromium.org/2494013003/. BUG=webrtc:6513 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [Chromoting] Build break after change 2494013003 One reference to the deprecated screen_capturer_mock_objects.h has been missed from change https://codereview.chromium.org/2494013003/. BUG=webrtc:6513 ========== to ========== [Chromoting] Build break after change 2494013003 One reference to the deprecated screen_capturer_mock_objects.h has been missed from change https://codereview.chromium.org/2494013003/. BUG=webrtc:6513 TBR=sergeyu@chromium.org, jamiewalch@chromium.org ==========
zijiehe@chromium.org changed reviewers: + jamiewalch@chromium.org, sergeyu@chromium.org
The CQ bit was checked by zijiehe@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== [Chromoting] Build break after change 2494013003 One reference to the deprecated screen_capturer_mock_objects.h has been missed from change https://codereview.chromium.org/2494013003/. BUG=webrtc:6513 TBR=sergeyu@chromium.org, jamiewalch@chromium.org ========== to ========== [Chromoting] Build break after change 2494013003 One reference to the deprecated screen_capturer_mock_objects.h has been missed from change https://codereview.chromium.org/2494013003/. BUG=webrtc:6513 TBR=sergeyu@chromium.org ==========
The CQ bit was checked by zijiehe@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
zijiehe@chromium.org changed reviewers: + kelvinp@chromium.org
lgtm
The CQ bit was checked by zijiehe@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Chromoting] Build break after change 2494013003 One reference to the deprecated screen_capturer_mock_objects.h has been missed from change https://codereview.chromium.org/2494013003/. BUG=webrtc:6513 TBR=sergeyu@chromium.org ========== to ========== [Chromoting] Build break after change 2494013003 One reference to the deprecated screen_capturer_mock_objects.h has been missed from change https://codereview.chromium.org/2494013003/. BUG=webrtc:6513 TBR=sergeyu@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Chromoting] Build break after change 2494013003 One reference to the deprecated screen_capturer_mock_objects.h has been missed from change https://codereview.chromium.org/2494013003/. BUG=webrtc:6513 TBR=sergeyu@chromium.org ========== to ========== [Chromoting] Build break after change 2494013003 One reference to the deprecated screen_capturer_mock_objects.h has been missed from change https://codereview.chromium.org/2494013003/. BUG=webrtc:6513 TBR=sergeyu@chromium.org Committed: https://crrev.com/38129a5549cd31ab14c5d7a970c0019a66f8bc40 Cr-Commit-Position: refs/heads/master@{#431758} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/38129a5549cd31ab14c5d7a970c0019a66f8bc40 Cr-Commit-Position: refs/heads/master@{#431758} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
