Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6917)

Unified Diff: chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

Issue 2491773002: Page Info (Views): remove images from accessibility order (Closed)
Patch Set: Move NonAccessibleImageView into a new class. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
diff --git a/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc b/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
index f182aabb5062b633a24b9fe0f81990f7708ac258..9896850d1b455bad5bcd1bc916a719fbf18c923c 100644
--- a/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
+++ b/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
@@ -25,6 +25,7 @@
#include "chrome/browser/ui/layout_constants.h"
#include "chrome/browser/ui/views/collected_cookies_views.h"
#include "chrome/browser/ui/views/website_settings/chosen_object_row.h"
+#include "chrome/browser/ui/views/website_settings/non_accessible_image_view.h"
#include "chrome/browser/ui/views/website_settings/permission_selector_row.h"
#include "chrome/browser/ui/website_settings/website_settings.h"
#include "chrome/common/pref_names.h"
@@ -39,6 +40,8 @@
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/user_metrics.h"
#include "extensions/common/constants.h"
+#include "ui/accessibility/ax_enums.h"
msw 2016/11/11 15:55:01 nit: remove
lgarron 2016/11/11 22:28:51 Removed.
+#include "ui/accessibility/ax_node_data.h"
msw 2016/11/11 15:55:01 nit: remove
lgarron 2016/11/11 22:28:51 Removed.
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/material_design/material_design_controller.h"
#include "ui/base/models/simple_menu_model.h"
@@ -369,7 +372,7 @@ InternalPageInfoPopupView::InternalPageInfoPopupView(
SetLayoutManager(new views::BoxLayout(views::BoxLayout::kHorizontal, kSpacing,
kSpacing, kSpacing));
set_margins(gfx::Insets());
- views::ImageView* icon_view = new views::ImageView();
+ views::ImageView* icon_view = new NonAccessibleImageView();
ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
icon_view->SetImage(rb.GetImageSkiaNamed(icon));
AddChildView(icon_view);
@@ -619,7 +622,7 @@ void WebsiteSettingsPopupView::SetCookieInfo(
info.is_incognito =
Profile::FromBrowserContext(web_contents()->GetBrowserContext())
->IsOffTheRecord();
- views::ImageView* icon = new views::ImageView();
+ views::ImageView* icon = new NonAccessibleImageView();
const gfx::Image& image = WebsiteSettingsUI::GetPermissionIcon(info);
icon->SetImage(image.ToImageSkia());
layout->AddView(

Powered by Google App Engine
This is Rietveld 408576698