Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7368)

Unified Diff: chrome/browser/ui/views/website_settings/permission_selector_row.cc

Issue 2491773002: Page Info (Views): remove images from accessibility order (Closed)
Patch Set: Move NonAccessibleImageView into a new class. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/website_settings/permission_selector_row.cc
diff --git a/chrome/browser/ui/views/website_settings/permission_selector_row.cc b/chrome/browser/ui/views/website_settings/permission_selector_row.cc
index a5792608069330abb39ce653fde76cf59828a7d1..b15b3ffa12f222232708b6f41cad06be5e1b5cbf 100644
--- a/chrome/browser/ui/views/website_settings/permission_selector_row.cc
+++ b/chrome/browser/ui/views/website_settings/permission_selector_row.cc
@@ -7,10 +7,12 @@
#include "base/i18n/rtl.h"
#include "base/macros.h"
#include "base/strings/utf_string_conversions.h"
+#include "chrome/browser/ui/views/website_settings/non_accessible_image_view.h"
#include "chrome/browser/ui/views/website_settings/website_settings_popup_view.h"
#include "chrome/browser/ui/website_settings/permission_menu_model.h"
#include "chrome/browser/ui/website_settings/website_settings_ui.h"
#include "chrome/grit/generated_resources.h"
+#include "ui/accessibility/ax_enums.h"
msw 2016/11/11 15:55:01 nit: remove
lgarron 2016/11/11 22:28:51 Removed.
#include "ui/accessibility/ax_node_data.h"
#include "ui/base/material_design/material_design_controller.h"
#include "ui/base/models/combobox_model.h"
@@ -28,7 +30,8 @@
namespace {
// Minimum distance between the label and its corresponding menu.
const int kMinSeparationBetweenLabelAndMenu = 16;
-}
+
msw 2016/11/11 15:55:01 nit: remove blank line, or add a matching one abov
lgarron 2016/11/11 22:28:51 Removed.
+} // namespace
namespace internal {
@@ -251,7 +254,7 @@ PermissionSelectorRow::PermissionSelectorRow(
layout->StartRow(1, column_set_id);
// Create the permission icon.
- icon_ = new views::ImageView();
+ icon_ = new NonAccessibleImageView();
const gfx::Image& image = WebsiteSettingsUI::GetPermissionIcon(permission);
icon_->SetImage(image.ToImageSkia());
layout->AddView(icon_,

Powered by Google App Engine
This is Rietveld 408576698