Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2491763004: Revert of Utilize FrameSelection::setSelection() taking SelectionInDOMTree/SelectionInFlatTree (Closed)

Created:
4 years, 1 month ago by aelias_OOO_until_Jul13
Modified:
4 years, 1 month ago
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Utilize FrameSelection::setSelection() taking SelectionInDOMTree/SelectionInFlatTree (patchset #3 id:40001 of https://codereview.chromium.org/2457613004/ ) Reason for revert: Caused http://b/32727536 Original issue's description: > Utilize FrameSelection::setSelection() taking SelectionInDOMTree/SelectionInFlatTree > > This patch changes |FrameSelection:setSelection()| taking |VisibleSelection| and > |VisibleSelectionInFlatTRee| to use |SelectionIn{DOM,Flat}Tree| to reduce > usage of |VisibleSelection{,InFlatTree}| for improving code health. > > BUG=657237 > TEST=n/a; no behavior changes > > Committed: https://crrev.com/1ab21eb247b8c05daf26de66bfb63a323c738866 > Cr-Commit-Position: refs/heads/master@{#428660} TBR=xiaochengh@chromium.org,yoichio@chromium.org,yosin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=657237 Committed: https://crrev.com/0acae5b3190e46c4a2cb8920753005b0e5daa36b Cr-Commit-Position: refs/heads/master@{#431357}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -30 lines) Patch
M third_party/WebKit/Source/core/editing/DOMSelection.cpp View 2 chunks +16 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 4 chunks +9 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 2 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionController.cpp View 2 chunks +13 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
aelias_OOO_until_Jul13
Created Revert of Utilize FrameSelection::setSelection() taking SelectionInDOMTree/SelectionInFlatTree
4 years, 1 month ago (2016-11-10 20:04:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491763004/1
4 years, 1 month ago (2016-11-10 20:05:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 21:23:40 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 21:34:46 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0acae5b3190e46c4a2cb8920753005b0e5daa36b
Cr-Commit-Position: refs/heads/master@{#431357}

Powered by Google App Engine
This is Rietveld 408576698