Chromium Code Reviews
DescriptionRevert of Utilize FrameSelection::setSelection() taking SelectionInDOMTree/SelectionInFlatTree (patchset #3 id:40001 of https://codereview.chromium.org/2457613004/ )
Reason for revert:
Caused http://b/32727536
Original issue's description:
> Utilize FrameSelection::setSelection() taking SelectionInDOMTree/SelectionInFlatTree
>
> This patch changes |FrameSelection:setSelection()| taking |VisibleSelection| and
> |VisibleSelectionInFlatTRee| to use |SelectionIn{DOM,Flat}Tree| to reduce
> usage of |VisibleSelection{,InFlatTree}| for improving code health.
>
> BUG=657237
> TEST=n/a; no behavior changes
>
> Committed: https://crrev.com/1ab21eb247b8c05daf26de66bfb63a323c738866
> Cr-Commit-Position: refs/heads/master@{#428660}
TBR=xiaochengh@chromium.org,yoichio@chromium.org,yosin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=657237
Committed: https://crrev.com/0acae5b3190e46c4a2cb8920753005b0e5daa36b
Cr-Commit-Position: refs/heads/master@{#431357}
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||