Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp

Issue 2491763004: Revert of Utilize FrameSelection::setSelection() taking SelectionInDOMTree/SelectionInFlatTree (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/SelectionController.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp b/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp
index ba97adde06d4a4a0985cfa399192096e2f4368a5..06bfba1032a949b501cb755950025ca85d6f116b 100644
--- a/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp
+++ b/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp
@@ -51,10 +51,12 @@
VisibleSelection oldSelection = document().frame()->selection().selection();
Position newPosition(input->innerEditorElement()->firstChild(), 3);
+ VisibleSelection newSelection = createVisibleSelection(
+ SelectionInDOMTree::Builder().collapse(newPosition).build());
document().frame()->selection().setSelection(
- SelectionInDOMTree::Builder().collapse(newPosition).build(),
- FrameSelection::CloseTyping | FrameSelection::ClearTypingStyle |
- FrameSelection::DoNotUpdateAppearance);
+ newSelection, FrameSelection::CloseTyping |
+ FrameSelection::ClearTypingStyle |
+ FrameSelection::DoNotUpdateAppearance);
ASSERT_EQ(3, input->selectionStart());
Persistent<SpellChecker> spellChecker(SpellChecker::create(page().frame()));
« no previous file with comments | « third_party/WebKit/Source/core/editing/SelectionController.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698