Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2491693003: Add tests for PresentationConnectionAvailable constructor. (Closed)

Created:
4 years, 1 month ago by mlamouri (slow - plz ping)
Modified:
4 years, 1 month ago
Reviewers:
mark a. foltz
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add tests for PresentationConnectionAvailable constructor. This is introducing a mock mojo presentation service in LayoutTests which could be used for future tests. BUG=648922 R=mfoltz@chromium.org Committed: https://crrev.com/703fb72fa7b04e34ea67a82d003b92a48f1a06c0 Cr-Commit-Position: refs/heads/master@{#432394}

Patch Set 1 #

Total comments: 8

Patch Set 2 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/presentation/presentationconnectionavailableevent-ctor.html View 1 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/presentation/presentationconnectionavailableevent-ctor-mock.html View 1 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/presentation/resources/presentation-service-mock.js View 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
mlamouri (slow - plz ping)
mfoltz@ PTAL
4 years, 1 month ago (2016-11-10 01:00:32 UTC) #3
mlamouri (slow - plz ping)
review ping :)
4 years, 1 month ago (2016-11-14 23:39:40 UTC) #6
mark a. foltz
Thank you for adding the mock presentation service, that will be very helpful going forward. ...
4 years, 1 month ago (2016-11-15 18:50:07 UTC) #7
mlamouri (slow - plz ping)
PTAL https://codereview.chromium.org/2491693003/diff/1/third_party/WebKit/LayoutTests/presentation/presentationconnectionavailableevent-ctor-mock.html File third_party/WebKit/LayoutTests/presentation/presentationconnectionavailableevent-ctor-mock.html (right): https://codereview.chromium.org/2491693003/diff/1/third_party/WebKit/LayoutTests/presentation/presentationconnectionavailableevent-ctor-mock.html#newcode11 third_party/WebKit/LayoutTests/presentation/presentationconnectionavailableevent-ctor-mock.html:11: function waitForClick(callback) { On 2016/11/15 at 18:50:07, mark ...
4 years, 1 month ago (2016-11-15 19:59:02 UTC) #8
mark a. foltz
https://codereview.chromium.org/2491693003/diff/1/third_party/WebKit/LayoutTests/presentation/presentationconnectionavailableevent-ctor-mock.html File third_party/WebKit/LayoutTests/presentation/presentationconnectionavailableevent-ctor-mock.html (right): https://codereview.chromium.org/2491693003/diff/1/third_party/WebKit/LayoutTests/presentation/presentationconnectionavailableevent-ctor-mock.html#newcode11 third_party/WebKit/LayoutTests/presentation/presentationconnectionavailableevent-ctor-mock.html:11: function waitForClick(callback) { On 2016/11/15 at 19:59:01, mlamouri (slow) ...
4 years, 1 month ago (2016-11-15 20:49:20 UTC) #9
mlamouri (slow - plz ping)
PTAL
4 years, 1 month ago (2016-11-15 22:06:15 UTC) #10
mark a. foltz
lgtm
4 years, 1 month ago (2016-11-15 22:53:25 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491693003/20001
4 years, 1 month ago (2016-11-16 05:41:57 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-16 06:31:06 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 06:33:34 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/703fb72fa7b04e34ea67a82d003b92a48f1a06c0
Cr-Commit-Position: refs/heads/master@{#432394}

Powered by Google App Engine
This is Rietveld 408576698