Add tests for PresentationConnectionAvailable constructor.

Add tests for PresentationConnectionAvailable constructor.

This is introducing a mock mojo presentation service in LayoutTests
which could be used for future tests.

BUG=648922
R=mfoltz@chromium.org

Committed: https://crrev.com/703fb72fa7b04e34ea67a82d003b92a48f1a06c0
Cr-Commit-Position: refs/heads/master@{#432394}

[mlamouri (slow - plz ping), 2016-11-10 00:59:42]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 01:00:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mlamouri (slow - plz ping), 2016-11-10 01:00:32]

mfoltz@ PTAL

[commit-bot: I haz the power, 2016-11-10 02:21:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 02:21:39]

Dry run: This issue passed the CQ dry run.

[mlamouri (slow - plz ping), 2016-11-14 23:39:40]

review ping :)

[mark a. foltz, 2016-11-15 18:50:07]

Thank you for adding the mock presentation service, that will be very helpful
going forward.

https://codereview.chromium.org/2491693003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/presentation/presentationconnectionavailableevent-ctor-mock.html
(right):

https://codereview.chromium.org/2491693003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/presentation/presentationconnectionavailableevent-ctor-mock.html:11:
function waitForClick(callback) {
This could return a Promise that is resolved by the button event listener, but I
don't feel strongly either way.

https://codereview.chromium.org/2491693003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/presentation/presentationconnectionavailableevent-ctor-mock.html:29:
waitForClick(t.step_func(_ => {
I'm a little fuzzy on when it's required to call t.step or t.step_func.  The
documentation suggests it's to add assertions after an asynchronous step.  But
does that also chain up to ancestor steps?

https://github.com/w3c/testharness.js/blob/master/docs/api.md

https://codereview.chromium.org/2491693003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/presentation/presentationconnectionavailableevent-ctor-mock.html:33:
'type', { connection: result });
What is the 'type' argument for?  It's not part of EventInit or
PresentationConnectionAvailableEventInit.

[mlamouri (slow - plz ping), 2016-11-15 19:59:02]

PTAL

https://codereview.chromium.org/2491693003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/presentation/presentationconnectionavailableevent-ctor-mock.html
(right):

https://codereview.chromium.org/2491693003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/presentation/presentationconnectionavailableevent-ctor-mock.html:11:
function waitForClick(callback) {
On 2016/11/15 at 18:50:07, mark a. foltz wrote:
> This could return a Promise that is resolved by the button event listener, but
I don't feel strongly either way.

Actually, it doesn't work because the promise isn't resolved synchronously so we
lose the user gesture token :(

https://codereview.chromium.org/2491693003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/presentation/presentationconnectionavailableevent-ctor-mock.html:29:
waitForClick(t.step_func(_ => {
On 2016/11/15 at 18:50:07, mark a. foltz wrote:
> I'm a little fuzzy on when it's required to call t.step or t.step_func.  The
documentation suggests it's to add assertions after an asynchronous step.  But
does that also chain up to ancestor steps?
> 
> https://github.com/w3c/testharness.js/blob/master/docs/api.md

I'm not sure what you mean by "chain up to ancestor steps". Though, you
understanding seems correct: it should be used for all async steps.

https://codereview.chromium.org/2491693003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/presentation/presentationconnectionavailableevent-ctor-mock.html:33:
'type', { connection: result });
On 2016/11/15 at 18:50:07, mark a. foltz wrote:
> What is the 'type' argument for?  It's not part of EventInit or
PresentationConnectionAvailableEventInit.

The constructors have a `type` argument. See the ctor of
PresentationConnectionAvailableEvent.

[mark a. foltz, 2016-11-15 20:49:20]

https://codereview.chromium.org/2491693003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/presentation/presentationconnectionavailableevent-ctor-mock.html
(right):

https://codereview.chromium.org/2491693003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/presentation/presentationconnectionavailableevent-ctor-mock.html:11:
function waitForClick(callback) {
On 2016/11/15 at 19:59:01, mlamouri (slow) wrote:
> On 2016/11/15 at 18:50:07, mark a. foltz wrote:
> > This could return a Promise that is resolved by the button event listener,
but I don't feel strongly either way.
> 
> Actually, it doesn't work because the promise isn't resolved synchronously so
we lose the user gesture token :(

I see.  Can you add a comment that this function is to obtain a user gesture
token?

https://codereview.chromium.org/2491693003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/presentation/presentationconnectionavailableevent-ctor-mock.html:33:
'type', { connection: result });
On 2016/11/15 at 19:59:01, mlamouri (slow) wrote:
> On 2016/11/15 at 18:50:07, mark a. foltz wrote:
> > What is the 'type' argument for?  It's not part of EventInit or
PresentationConnectionAvailableEventInit.
> 
> The constructors have a `type` argument. See the ctor of
PresentationConnectionAvailableEvent.

Can you pass the correct type name then (connectionavailable)?

Not clear to my why this isn't done by the bindings.

[mlamouri (slow - plz ping), 2016-11-15 22:06:15]

PTAL

[mlamouri (slow - plz ping), 2016-11-15 22:06:16]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 22:07:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 22:42:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 22:42:39]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[mark a. foltz, 2016-11-15 22:53:25]

lgtm

[mlamouri (slow - plz ping), 2016-11-16 05:41:35]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2016-11-16 05:41:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 06:31:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-16 06:33:33]

Description was changed from

==========
Add tests for PresentationConnectionAvailable constructor.

This is introducing a mock mojo presentation service in LayoutTests
which could be used for future tests.

BUG=648922
R=mfoltz@chromium.org
==========

to

==========
Add tests for PresentationConnectionAvailable constructor.

This is introducing a mock mojo presentation service in LayoutTests
which could be used for future tests.

BUG=648922
R=mfoltz@chromium.org

Committed: https://crrev.com/703fb72fa7b04e34ea67a82d003b92a48f1a06c0
Cr-Commit-Position: refs/heads/master@{#432394}
==========

[commit-bot: I haz the power, 2016-11-16 06:33:34]

Patchset 2 (id:??) landed as
https://crrev.com/703fb72fa7b04e34ea67a82d003b92a48f1a06c0
Cr-Commit-Position: refs/heads/master@{#432394}