third_party/WebKit/LayoutTests/presentation/presentationconnectionavailableevent-ctor-mock.html - Issue 2491693003: Add tests for PresentationConnectionAvailable constructor.

Side by Side Diff: third_party/WebKit/LayoutTests/presentation/presentationconnectionavailableevent-ctor-mock.html

Issue 2491693003: Add tests for PresentationConnectionAvailable constructor. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « third_party/WebKit/LayoutTests/presentation/presentationconnectionavailableevent-ctor.html ('k') | third_party/WebKit/LayoutTests/presentation/resources/presentation-service-mock.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <script src="../resources/testharness.js"></script>

	5 <script src="../resources/testharnessreport.js"></script>

	6 <script src="../resources/mojo-helpers.js"></script>

	7 <script src="resources/presentation-service-mock.js"></script>

	8 <button>click me</button>

	9 <script>

	10

	11 function waitForClick(callback) {
	mark a. foltz 2016/11/15 18:50:07 This could return a Promise that is resolved by th This could return a Promise that is resolved by the button event listener, but I don't feel strongly either way. mlamouri (slow - plz ping) 2016/11/15 19:59:01 Actually, it doesn't work because the promise isn' Show quoted text On 2016/11/15 at 18:50:07, mark a. foltz wrote: > This could return a Promise that is resolved by the button event listener, but I don't feel strongly either way. Actually, it doesn't work because the promise isn't resolved synchronously so we lose the user gesture token :( mark a. foltz 2016/11/15 20:49:20 I see. Can you add a comment that this function i Show quoted text On 2016/11/15 at 19:59:01, mlamouri (slow) wrote: > On 2016/11/15 at 18:50:07, mark a. foltz wrote: > > This could return a Promise that is resolved by the button event listener, but I don't feel strongly either way. > > Actually, it doesn't work because the promise isn't resolved synchronously so we lose the user gesture token :( I see. Can you add a comment that this function is to obtain a user gesture token?
	12 var button = document.querySelector('button');

	13 button.addEventListener('click', callback, { once: true });

	14

	15 if (!('eventSender' in window))

	16 return;

	17

	18 var boundingRect = button.getBoundingClientRect();

	19 var x = boundingRect.left + boundingRect.width / 2;

	20 var y = boundingRect.top + boundingRect.height / 2;

	21

	22 eventSender.mouseMoveTo(x, y);

	23 eventSender.mouseDown();

	24 eventSender.mouseUp();

	25 }

	26

	27 async_test(t => {

	28 presentationServiceMock.then(t.step_func(mockService => {

	29 waitForClick(t.step_func(_ => {
	mark a. foltz 2016/11/15 18:50:07 I'm a little fuzzy on when it's required to call t I'm a little fuzzy on when it's required to call t.step or t.step_func. The documentation suggests it's to add assertions after an asynchronous step. But does that also chain up to ancestor steps? https://github.com/w3c/testharness.js/blob/master/docs/api.md mlamouri (slow - plz ping) 2016/11/15 19:59:01 I'm not sure what you mean by "chain up to ancesto Show quoted text On 2016/11/15 at 18:50:07, mark a. foltz wrote: > I'm a little fuzzy on when it's required to call t.step or t.step_func. The documentation suggests it's to add assertions after an asynchronous step. But does that also chain up to ancestor steps? > > https://github.com/w3c/testharness.js/blob/master/docs/api.md I'm not sure what you mean by "chain up to ancestor steps". Though, you understanding seems correct: it should be used for all async steps.
	30 new PresentationRequest('https://example.com').start().then(

	31 t.step_func_done(result => {

	32 var e = new PresentationConnectionAvailableEvent(

	33 'type', { connection: result });
	mark a. foltz 2016/11/15 18:50:07 What is the 'type' argument for? It's not part of What is the 'type' argument for? It's not part of EventInit or PresentationConnectionAvailableEventInit. mlamouri (slow - plz ping) 2016/11/15 19:59:01 The constructors have a `type` argument. See the c Show quoted text On 2016/11/15 at 18:50:07, mark a. foltz wrote: > What is the 'type' argument for? It's not part of EventInit or PresentationConnectionAvailableEventInit. The constructors have a `type` argument. See the ctor of PresentationConnectionAvailableEvent. mark a. foltz 2016/11/15 20:49:20 Can you pass the correct type name then (connectio Show quoted text On 2016/11/15 at 19:59:01, mlamouri (slow) wrote: > On 2016/11/15 at 18:50:07, mark a. foltz wrote: > > What is the 'type' argument for? It's not part of EventInit or PresentationConnectionAvailableEventInit. > > The constructors have a `type` argument. See the ctor of PresentationConnectionAvailableEvent. Can you pass the correct type name then (connectionavailable)? Not clear to my why this isn't done by the bindings.
	34 assert_not_equals(e, null);

	35 assert_equals(e.connection, result);

	36 }));

	37 }));

	38 }));

	39 }, "Test that the PresentationConnectionAvailableEvent ctor can take a valid Pre sentationConnection.")

	40

	41 </script>

	42 </body>

	43 </html>

OLD	NEW