Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: third_party/WebKit/Source/modules/webaudio/OfflineAudioCompletionEvent.h

Issue 2491653002: Add constructors for WebAudio events (Closed)
Patch Set: Add links to spec. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/OfflineAudioCompletionEvent.h
diff --git a/third_party/WebKit/Source/modules/webaudio/OfflineAudioCompletionEvent.h b/third_party/WebKit/Source/modules/webaudio/OfflineAudioCompletionEvent.h
index 8353caefd5424f9eec85b6d46d4ed7ad01e281be..c6909573db60ab7501e033362636f14ce24cc7cd 100644
--- a/third_party/WebKit/Source/modules/webaudio/OfflineAudioCompletionEvent.h
+++ b/third_party/WebKit/Source/modules/webaudio/OfflineAudioCompletionEvent.h
@@ -28,12 +28,15 @@
#include "modules/EventModules.h"
#include "modules/webaudio/AudioBuffer.h"
+#include "modules/webaudio/OfflineAudioCompletionEventInit.h"
+
#include "wtf/PassRefPtr.h"
#include "wtf/RefPtr.h"
namespace blink {
class AudioBuffer;
+class OfflineAudioCompletionEventInit;
class OfflineAudioCompletionEvent final : public Event {
DEFINE_WRAPPERTYPEINFO();
@@ -41,6 +44,9 @@ class OfflineAudioCompletionEvent final : public Event {
public:
static OfflineAudioCompletionEvent* create();
static OfflineAudioCompletionEvent* create(AudioBuffer* renderedBuffer);
+ static OfflineAudioCompletionEvent* create(
+ const AtomicString& eventType,
+ const OfflineAudioCompletionEventInit&);
~OfflineAudioCompletionEvent() override;
@@ -53,6 +59,8 @@ class OfflineAudioCompletionEvent final : public Event {
private:
OfflineAudioCompletionEvent();
explicit OfflineAudioCompletionEvent(AudioBuffer* renderedBuffer);
+ explicit OfflineAudioCompletionEvent(const AtomicString&,
foolip 2016/11/15 19:53:33 Include argument name (type)
hongchan 2016/12/02 18:07:17 What about the second one? I thought Chromium conv
Raymond Toy 2016/12/02 18:50:00 I think AtomicString& by itself carries no info ab
+ const OfflineAudioCompletionEventInit&);
Member<AudioBuffer> m_renderedBuffer;
};

Powered by Google App Engine
This is Rietveld 408576698