Add constructors for WebAudio events

third_party/WebKit/Source/modules/webaudio/OfflineAudioCompletionEvent.h

 /*
  * Copyright (C) 2011, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 10 matching lines @@
  * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
  * DAMAGE.
  */
 
 #ifndef OfflineAudioCompletionEvent_h
 #define OfflineAudioCompletionEvent_h
 
 #include "modules/EventModules.h"
 #include "modules/webaudio/AudioBuffer.h"
+#include "modules/webaudio/OfflineAudioCompletionEventInit.h"
+
 #include "wtf/PassRefPtr.h"
 #include "wtf/RefPtr.h"
 
 namespace blink {
 
 class AudioBuffer;
+class OfflineAudioCompletionEventInit;
 
 class OfflineAudioCompletionEvent final : public Event {
   DEFINE_WRAPPERTYPEINFO();
 
  public:
   static OfflineAudioCompletionEvent* create();
   static OfflineAudioCompletionEvent* create(AudioBuffer* renderedBuffer);
+  static OfflineAudioCompletionEvent* create(
+      const AtomicString& eventType,
+      const OfflineAudioCompletionEventInit&);
 
   ~OfflineAudioCompletionEvent() override;
 
   AudioBuffer* renderedBuffer() { return m_renderedBuffer.get(); }
 
   const AtomicString& interfaceName() const override;
 
   DECLARE_VIRTUAL_TRACE();
 
  private:
   OfflineAudioCompletionEvent();
   explicit OfflineAudioCompletionEvent(AudioBuffer* renderedBuffer);
+  explicit OfflineAudioCompletionEvent(const AtomicString&,

[foolip, 2016/11/15 19:53:33]

Include argument name (type)

[hongchan, 2016/12/02 18:07:17]

What about the second one? I thought Chromium convention is to omit the variable
names in the heather when it's possible.

[Raymond Toy, 2016/12/02 18:50:00]

I think AtomicString& by itself carries no info about what the arg does.  But
OfflineAudioCompletionEventInit pretty clearly tells you what the arg does even
without an arg name.

+                                       const OfflineAudioCompletionEventInit&);
 
   Member<AudioBuffer> m_renderedBuffer;
 };
 
 }  // namespace blink
 
 #endif  // OfflineAudioCompletionEvent_h