Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1083)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioProcessingEvent.h

Issue 2491653002: Add constructors for WebAudio events (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/AudioProcessingEvent.h
diff --git a/third_party/WebKit/Source/modules/webaudio/AudioProcessingEvent.h b/third_party/WebKit/Source/modules/webaudio/AudioProcessingEvent.h
index a85b8de0fbae1b77a3e9ea8abad1767953effa69..820a16ae17beecaf820ec6933e3cfd0c351b8700 100644
--- a/third_party/WebKit/Source/modules/webaudio/AudioProcessingEvent.h
+++ b/third_party/WebKit/Source/modules/webaudio/AudioProcessingEvent.h
@@ -28,12 +28,15 @@
#include "modules/EventModules.h"
#include "modules/webaudio/AudioBuffer.h"
+#include "modules/webaudio/AudioProcessingEventInit.h"
+
tkent 2016/12/05 23:38:35 nit: This blink line is unnecessary.
Raymond Toy 2016/12/06 00:10:58 Done.
#include "wtf/PassRefPtr.h"
#include "wtf/RefPtr.h"
namespace blink {
class AudioBuffer;
+class AudioProcessingEventInit;
class AudioProcessingEvent final : public Event {
DEFINE_WRAPPERTYPEINFO();
@@ -44,6 +47,9 @@ class AudioProcessingEvent final : public Event {
AudioBuffer* outputBuffer,
double playbackTime);
+ static AudioProcessingEvent* create(const AtomicString& type,
hongchan 2016/12/02 18:07:17 Or we can just remove the variable name itself to
Raymond Toy 2016/12/02 18:50:00 No, I agree with foolip (in another comment). Thi
+ const AudioProcessingEventInit&);
+
~AudioProcessingEvent() override;
AudioBuffer* inputBuffer() { return m_inputBuffer.get(); }
@@ -59,6 +65,8 @@ class AudioProcessingEvent final : public Event {
AudioProcessingEvent(AudioBuffer* inputBuffer,
AudioBuffer* outputBuffer,
double playbackTime);
+ AudioProcessingEvent(const AtomicString& type,
+ const AudioProcessingEventInit&);
Member<AudioBuffer> m_inputBuffer;
Member<AudioBuffer> m_outputBuffer;

Powered by Google App Engine
This is Rietveld 408576698