Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioProcessingEvent.cpp

Issue 2491653002: Add constructors for WebAudio events (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/AudioProcessingEvent.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/AudioProcessingEvent.cpp b/third_party/WebKit/Source/modules/webaudio/AudioProcessingEvent.cpp
index dd9562c6b161db772df19e8caf728770d475211d..273fa3361a0b06d0b515fe2bd604a9c913106057 100644
--- a/third_party/WebKit/Source/modules/webaudio/AudioProcessingEvent.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/AudioProcessingEvent.cpp
@@ -25,6 +25,8 @@
#include "modules/webaudio/AudioProcessingEvent.h"
tkent 2016/12/05 23:38:35 This blank line is unnecessary.
Raymond Toy 2016/12/06 00:10:57 Done.
+#include "modules/webaudio/AudioProcessingEventInit.h"
+
namespace blink {
AudioProcessingEvent* AudioProcessingEvent::create() {
@@ -37,6 +39,12 @@ AudioProcessingEvent* AudioProcessingEvent::create(AudioBuffer* inputBuffer,
return new AudioProcessingEvent(inputBuffer, outputBuffer, playbackTime);
}
+AudioProcessingEvent* AudioProcessingEvent::create(
+ const AtomicString& type,
+ const AudioProcessingEventInit& initializer) {
+ return new AudioProcessingEvent(type, initializer);
hongchan 2016/12/02 18:07:17 I think |eventInit| is better. |initializer| sound
Raymond Toy 2016/12/02 18:50:00 I think I was following other existing code, but e
+}
+
AudioProcessingEvent::AudioProcessingEvent() {}
AudioProcessingEvent::AudioProcessingEvent(AudioBuffer* inputBuffer,
@@ -47,6 +55,15 @@ AudioProcessingEvent::AudioProcessingEvent(AudioBuffer* inputBuffer,
m_outputBuffer(outputBuffer),
m_playbackTime(playbackTime) {}
+AudioProcessingEvent::AudioProcessingEvent(
+ const AtomicString& type,
+ const AudioProcessingEventInit& initializer)
+ : Event(type, initializer) {
+ m_inputBuffer = initializer.inputBuffer();
+ m_outputBuffer = initializer.outputBuffer();
+ m_playbackTime = initializer.playbackTime();
+}
+
AudioProcessingEvent::~AudioProcessingEvent() {}
const AtomicString& AudioProcessingEvent::interfaceName() const {

Powered by Google App Engine
This is Rietveld 408576698