Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2491603003: media: Set stricter visibility for //media/base (Closed)

Created:
4 years, 1 month ago by xhwang
Modified:
4 years, 1 month ago
Reviewers:
watk
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Set stricter visibility for //media/base Target //media/base is a source set. Having targets depending on it (and quite often depending on //media as well) could easily cause duplicated symbols. This has been seen in multiple codereviews recently. This CL make the visibility rule stricter to avoid this issue. BUG=599578 R=watk@chromium.org Committed: https://crrev.com/5efed7b22c6fd37f646333085257edc9becd9586 Cr-Commit-Position: refs/heads/master@{#431356}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M media/base/BUILD.gn View 1 chunk +12 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
xhwang
4 years, 1 month ago (2016-11-10 05:59:23 UTC) #1
xhwang
PTAL
4 years, 1 month ago (2016-11-10 06:00:12 UTC) #3
watk
lgtm
4 years, 1 month ago (2016-11-10 19:41:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491603003/1
4 years, 1 month ago (2016-11-10 21:14:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 21:18:59 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 21:23:45 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5efed7b22c6fd37f646333085257edc9becd9586
Cr-Commit-Position: refs/heads/master@{#431356}

Powered by Google App Engine
This is Rietveld 408576698