Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: media/base/BUILD.gn

Issue 2491603003: media: Set stricter visibility for //media/base (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/BUILD.gn
diff --git a/media/base/BUILD.gn b/media/base/BUILD.gn
index 4b6d9e9239dfcc6281af611146e2bde49110330d..136b4fd08ed79ab73bde79a0acce45af163fcd87 100644
--- a/media/base/BUILD.gn
+++ b/media/base/BUILD.gn
@@ -28,8 +28,18 @@ if (is_component_build) {
link_target_type = "static_library"
}
target(link_target_type, "base") {
- # This is part of the media component.
- visibility = [ "//media/*" ]
+ # This should only be depended on by "media" target. Other targets should
+ # depend on "media" target directly.
+ visibility = [
+ "//media",
+
+ # TODO(xhwang): Clean up the dependency graph within "media" target.
+ "//media/audio",
+ "//media/ffmpeg",
+
+ # TODO(xhwang): Remove this dependency.
+ "//media/capture",
+ ]
sources = [
"audio_block_fifo.cc",
"audio_block_fifo.h",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698