Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2491513002:
[Payment] Clean up PaymentResponse::toJSONForBinding (Closed)
Description[Payment] Clean up PaymentResponse::toJSONForBinding
When https://codereview.chromium.org/2476393003/ is landed.
We could clean up toJSONForBinding.
BUG=648051
Committed: https://crrev.com/58f500b5bb9149f63c2c42c1977ead5a2692eb25
Cr-Commit-Position: refs/heads/master@{#431269}
Patch Set 1 #
Total comments: 1
Patch Set 2 : rebase #Messages
Total messages: 23 (13 generated)
Description was changed from ========== [Payment]Clean up PaymentResponse::toJSONForBinding When https://codereview.chromium.org/2476393003/ is landed. We could clean up toJSONForBinding. ========== to ========== [Payment]Clean up PaymentResponse::toJSONForBinding When https://codereview.chromium.org/2476393003/ is landed. We could clean up toJSONForBinding. ==========
corona10@gmail.com changed reviewers: + jinho.bang@samsung.com
@zino PTAL
jinho.bang@samsung.com changed reviewers: + rouslan@chromium.org
Description was changed from ========== [Payment]Clean up PaymentResponse::toJSONForBinding When https://codereview.chromium.org/2476393003/ is landed. We could clean up toJSONForBinding. ========== to ========== [Payment] Clean up PaymentResponse::toJSONForBinding When https://codereview.chromium.org/2476393003/ is landed. We could clean up toJSONForBinding. ==========
lgtm rouslan@ PTAL
https://codereview.chromium.org/2491513002/diff/1/third_party/WebKit/Source/m... File third_party/WebKit/Source/modules/payments/PaymentResponse.cpp (right): https://codereview.chromium.org/2491513002/diff/1/third_party/WebKit/Source/m... third_party/WebKit/Source/modules/payments/PaymentResponse.cpp:46: .addStringOrNull("payerPhone", payerPhone()); You're missing payerName
Please specify BUG=NUMBER on the last line of your CL description.
dhna@, You probably should rebase your code. Recently, this patch was landed https://codereview.chromium.org/2473053003/.
On 2016/11/09 20:00:04, zino wrote: > dhna@, > > You probably should rebase your code. > Recently, this patch was landed https://codereview.chromium.org/2473053003/. zino@ Thanks, I rebase my code and upload again. rouslan@ My code was outdated. so I rebase my code and commit again. Anyway done.
Description was changed from ========== [Payment] Clean up PaymentResponse::toJSONForBinding When https://codereview.chromium.org/2476393003/ is landed. We could clean up toJSONForBinding. ========== to ========== [Payment] Clean up PaymentResponse::toJSONForBinding When https://codereview.chromium.org/2476393003/ is landed. We could clean up toJSONForBinding. BUG=648051 ==========
The CQ bit was checked by corona10@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by rouslan@chromium.org
lgtm
The patchset sent to the CQ was uploaded after l-g-t-m from jinho.bang@samsung.com Link to the patchset: https://codereview.chromium.org/2491513002/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Payment] Clean up PaymentResponse::toJSONForBinding When https://codereview.chromium.org/2476393003/ is landed. We could clean up toJSONForBinding. BUG=648051 ========== to ========== [Payment] Clean up PaymentResponse::toJSONForBinding When https://codereview.chromium.org/2476393003/ is landed. We could clean up toJSONForBinding. BUG=648051 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Payment] Clean up PaymentResponse::toJSONForBinding When https://codereview.chromium.org/2476393003/ is landed. We could clean up toJSONForBinding. BUG=648051 ========== to ========== [Payment] Clean up PaymentResponse::toJSONForBinding When https://codereview.chromium.org/2476393003/ is landed. We could clean up toJSONForBinding. BUG=648051 Committed: https://crrev.com/58f500b5bb9149f63c2c42c1977ead5a2692eb25 Cr-Commit-Position: refs/heads/master@{#431269} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/58f500b5bb9149f63c2c42c1977ead5a2692eb25 Cr-Commit-Position: refs/heads/master@{#431269} |
