Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2473053003: Convert payer name to JSON (Closed)

Created:
4 years, 1 month ago by please use gerrit instead
Modified:
4 years, 1 month ago
Reviewers:
zino
CC:
chromium-reviews, blink-reviews, haraken, sebsg+paymentswatch_chromium.org, rouslan+payments_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert payer name to JSON BUG=648051 Committed: https://crrev.com/3ca19609a118633765552eb3e8282b3d8c4385f0 Cr-Commit-Position: refs/heads/master@{#430313}

Patch Set 1 #

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/payments/PaymentResponse.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
please use gerrit instead
jinho.bang, ptal.
4 years, 1 month ago (2016-11-03 19:09:17 UTC) #4
zino
On 2016/11/03 19:09:17, rouslan wrote: > jinho.bang, ptal. lgtm. Could you please update PaymentResponseTest.JSONSerializer for ...
4 years, 1 month ago (2016-11-04 01:26:40 UTC) #7
please use gerrit instead
On 2016/11/04 01:26:40, zino wrote: > Could you please update PaymentResponseTest.JSONSerializer for this? > https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp?q=paymentresponsetest&sq=package:chromium&l=120 ...
4 years, 1 month ago (2016-11-07 15:51:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2473053003/20001
4 years, 1 month ago (2016-11-07 15:51:25 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-07 18:03:35 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 18:14:36 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3ca19609a118633765552eb3e8282b3d8c4385f0
Cr-Commit-Position: refs/heads/master@{#430313}

Powered by Google App Engine
This is Rietveld 408576698