appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py - Issue 2491473002: [Findit] Implementing swarming task error detection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py

Issue 2491473002: [Findit] Implementing swarming task error detection (Closed)

Patch Set: Rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py ('k') | appengine/findit/waterfall/process_swarming_task_result_pipeline.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py

diff --git a/appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py b/appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py

index b37ddc13c31c5c4249423003230533bb4a7cf3b4..0e46d33aeb59967e8aab4023bfbb66dcaf9c01b8 100644

--- a/appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py

+++ b/appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py

@@ -44,9 +44,11 @@ class ProcessFlakeSwarmingTaskResultPipeline(

tests_statuses = super(ProcessFlakeSwarmingTaskResultPipeline,

self)._CheckTestsRunStatuses(output_json)

# Should query by test name, because some test has dependencies which

# are also run, like TEST and PRE_TEST in browser_tests.

+ tests_statuses = super(ProcessFlakeSwarmingTaskResultPipeline,

+ self)._CheckTestsRunStatuses(output_json)

tries = tests_statuses.get(test_name, {}).get('total_run', 0)

successes = tests_statuses.get(test_name, {}).get('SUCCESS', 0)

@@ -61,6 +63,7 @@ class ProcessFlakeSwarmingTaskResultPipeline(

logging.info(

'Updating MasterFlakeAnalysis data %s/%s/%s/%s/%s',

master_name, builder_name, master_build_number, step_name, test_name)

logging.info('MasterFlakeAnalysis %s version %s',

master_flake_analysis, master_flake_analysis.version_number)