[Findit] Implementing swarming task error detection

appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 
 from model.flake.flake_swarming_task import FlakeSwarmingTask
 from model.flake.master_flake_analysis import DataPoint
 from model.flake.master_flake_analysis import MasterFlakeAnalysis
 from waterfall.process_base_swarming_task_result_pipeline import (
@@ skipping 26 matching lines @@
 
     Returns:
       tests_statuses (dict): A dict of different statuses for each test.
 
     Currently for each test, we are saving number of total runs,
     number of succeeded runs and number of failed runs.
     """
 
     tests_statuses = super(ProcessFlakeSwarmingTaskResultPipeline,
                            self)._CheckTestsRunStatuses(output_json)
-
     # Should query by test name, because some test has dependencies which
     # are also run, like TEST and PRE_TEST in browser_tests.
+    tests_statuses = super(ProcessFlakeSwarmingTaskResultPipeline,
+                           self)._CheckTestsRunStatuses(output_json)
+
     tries = tests_statuses.get(test_name, {}).get('total_run', 0)
     successes = tests_statuses.get(test_name, {}).get('SUCCESS', 0)
 
     if tries > 0:
       pass_rate = successes * 1.0 / tries
     else:
       pass_rate = -1  # Special value to indicate test is not existing.
 
     master_flake_analysis = MasterFlakeAnalysis.GetVersion(
         master_name, builder_name, master_build_number, step_name, test_name,
         version=version_number)
     logging.info(
         'Updating MasterFlakeAnalysis data %s/%s/%s/%s/%s',
         master_name, builder_name, master_build_number, step_name, test_name)
+
     logging.info('MasterFlakeAnalysis %s version %s',
                  master_flake_analysis, master_flake_analysis.version_number)
 
     data_point = DataPoint()
     data_point.build_number = build_number
     data_point.pass_rate = pass_rate
     master_flake_analysis.data_points.append(data_point)
 
     flake_swarming_task = FlakeSwarmingTask.Get(
         master_name, builder_name, build_number, step_name, test_name)
@@ skipping 18 matching lines @@
     return (master_name, builder_name, build_number, step_name,
             master_build_number, test_name, version_number)
 
   # Unused Argument - pylint: disable=W0612,W0613
   # Arguments number differs from overridden method - pylint: disable=W0221
   def _GetSwarmingTask(self, master_name, builder_name, build_number,
                        step_name, master_build_number, test_name, _):
     # Gets the appropriate kind of swarming task (FlakeSwarmingTask).
     return FlakeSwarmingTask.Get(master_name, builder_name, build_number,
                                  step_name, test_name)