Chromium Code Reviews| Index: appengine/findit/waterfall/trigger_swarming_task_pipeline.py |
| diff --git a/appengine/findit/waterfall/trigger_swarming_task_pipeline.py b/appengine/findit/waterfall/trigger_swarming_task_pipeline.py |
| index 0c683b56a08c01978461bf16e12d97f1e3ba86e8..ea95f90742357b38dedb02f00eac5dbbfe1ee03d 100644 |
| --- a/appengine/findit/waterfall/trigger_swarming_task_pipeline.py |
| +++ b/appengine/findit/waterfall/trigger_swarming_task_pipeline.py |
| @@ -16,6 +16,9 @@ from model.wf_swarming_task import WfSwarmingTask |
| from waterfall import swarming_util |
| from waterfall import waterfall_config |
| +# TODO(lijeffrey): Refactor and merge this file with |
| +# trigger_base_swarming_task_pipeline. |
| + |
| def _GetSwarmingTaskName(ref_task_id): # pragma: no cover. |
| """Returns a unique task name. |
| @@ -151,12 +154,14 @@ class TriggerSwarmingTaskPipeline(BasePipeline): |
| step_name, tests, iterations_to_rerun) |
| # 3. Trigger a new Swarming task to re-run the failed tests. |
| - task_id = swarming_util.TriggerSwarmingTask(new_request, http_client) |
| + task_id, error = swarming_util.TriggerSwarmingTask(new_request, http_client) |
| # Save the task id. |
| swarming_task = WfSwarmingTask.Get( |
| master_name, builder_name, build_number, step_name) |
| swarming_task.task_id = task_id |
| + if error: |
| + swarming_task.error = error |
|
chanli
2016/11/11 00:05:13
Comments of trigger_base_swarming_task_pipeline.py
lijeffrey
2016/11/11 20:55:41
Done. This file will be refactored in an upcoming
|
| swarming_task.parameters['tests'] = tests |
| swarming_task.parameters['iterations_to_rerun'] = iterations_to_rerun |
| swarming_task.parameters['ref_name'] = swarming_util.GetTagValue( |