[Findit] Implementing swarming task error detection

appengine/findit/waterfall/trigger_swarming_task_pipeline.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import copy
 import logging
 import time
 
 from google.appengine.ext import ndb
 
 from common.http_client_appengine import HttpClientAppengine as HttpClient
 from common.pipeline_wrapper import BasePipeline
 from lib import time_util
 from model import analysis_status
 from model.wf_swarming_task import WfSwarmingTask
 from waterfall import swarming_util
 from waterfall import waterfall_config
 
+# TODO(lijeffrey): Refactor and merge this file with
+# trigger_base_swarming_task_pipeline.
+
 
 def _GetSwarmingTaskName(ref_task_id):  # pragma: no cover.
   """Returns a unique task name.
 
   Have this separate function in order to mock for testing purpose.
   """
   return 'findit/deflake/ref_task_id/%s/%s' % (
       ref_task_id, time_util.GetUTCNow().strftime('%Y-%m-%d %H:%M:%S %f'))
 
 
@@ skipping 115 matching lines @@
         ref_task_id, http_client)
 
     # 2. Update/Overwrite parameters for the re-run.
     iterations_to_rerun = waterfall_config.GetSwarmingSettings().get(
         'iterations_to_rerun')
     new_request = _CreateNewSwarmingTaskRequest(
         ref_task_id, ref_request, master_name, builder_name, build_number,
         step_name, tests, iterations_to_rerun)
 
     # 3. Trigger a new Swarming task to re-run the failed tests.
-    task_id = swarming_util.TriggerSwarmingTask(new_request, http_client)
+    task_id, error = swarming_util.TriggerSwarmingTask(new_request, http_client)
 
     # Save the task id.
     swarming_task = WfSwarmingTask.Get(
         master_name, builder_name, build_number, step_name)
     swarming_task.task_id = task_id
+    if error:
+      swarming_task.error = error

[chanli, 2016/11/11 00:05:13]

Comments of trigger_base_swarming_task_pipeline.py apply here

[lijeffrey, 2016/11/11 20:55:41]

Done. This file will be refactored in an upcoming CL as well, so this shouldn't
be a duplicated issue any longer

     swarming_task.parameters['tests'] = tests
     swarming_task.parameters['iterations_to_rerun'] = iterations_to_rerun
     swarming_task.parameters['ref_name'] = swarming_util.GetTagValue(
         new_request.tags, 'ref_name')
     swarming_task.put()
 
     logging.info('A Swarming task was triggered:%s', task_id)
     return task_id