|
Revert of Windows install_static refactor. (patchset #15 id:320001 of https://codereview.chromium.org/2422643002/ )
Reason for revert:
Causes a crash at uninstall; see https://crbug.com/663703.
Original issue's description:
> Windows install_static refactor.
>
> This change introduces install_static::InstallDetails, a module-global
> holder of details relating to the current install. It also more clearly
> defines the concept of a primary install mode and one or more secondary
> install modes (e.g., "Chrome SxS" for Google Chrome's canary channel).
> Furthermore, it creates a clear boundary for brand-specific constants so
> that Chromium and Google Chrome don't bleed into one another. See
> chrome/install_static/README.md for more information.
>
> BUG= 373987
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
>
> Committed: https://crrev.com/92bc27b8b101d2b300a7b3afd79265b3cfba1152
> Cr-Commit-Position: refs/heads/master@{#430728}
TBR=ananta@chromium.org,robertshield@chromium.org,siggi@chromium.org,pennymac@chromium.org,thakis@chromium.org,bradnelson@chromium.org,phajdan.jr@chromium.org,dschuff@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 373987
Committed: https://crrev.com/51c82a0a7e700d1041511175dbc458c616fde61e
Cr-Commit-Position: refs/heads/master@{#430914}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+980 lines, -1950 lines) |
Patch |
|
M |
chrome/app/chrome_crash_reporter_client_win.cc
|
View
|
|
2 chunks |
+13 lines, -11 lines |
0 comments
|
Download
|
|
M |
chrome/app/chrome_exe_main_win.cc
|
View
|
|
3 chunks |
+2 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/app/chrome_main.cc
|
View
|
|
4 chunks |
+1 line, -12 lines |
0 comments
|
Download
|
|
M |
chrome/app/main_dll_loader_win.cc
|
View
|
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/chrome_watcher/BUILD.gn
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
chrome/chrome_watcher/DEPS
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/chrome_watcher/chrome_watcher_main.cc
|
View
|
|
2 chunks |
+4 lines, -5 lines |
0 comments
|
Download
|
|
M |
chrome/chrome_watcher/chrome_watcher_main_api.h
|
View
|
|
1 chunk |
+4 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/install_static/BUILD.gn
|
View
|
|
2 chunks |
+0 lines, -26 lines |
0 comments
|
Download
|
|
M |
chrome/install_static/DEPS
|
View
|
|
1 chunk |
+1 line, -10 lines |
0 comments
|
Download
|
|
D |
chrome/install_static/README.md
|
View
|
|
1 chunk |
+0 lines, -10 lines |
0 comments
|
Download
|
|
D |
chrome/install_static/chromium_install_modes.h
|
View
|
|
1 chunk |
+0 lines, -23 lines |
0 comments
|
Download
|
|
D |
chrome/install_static/chromium_install_modes.cc
|
View
|
|
1 chunk |
+0 lines, -41 lines |
0 comments
|
Download
|
|
D |
chrome/install_static/google_chrome_install_modes.h
|
View
|
|
1 chunk |
+0 lines, -24 lines |
0 comments
|
Download
|
|
D |
chrome/install_static/google_chrome_install_modes.cc
|
View
|
|
1 chunk |
+0 lines, -51 lines |
0 comments
|
Download
|
|
D |
chrome/install_static/install_constants.h
|
View
|
|
1 chunk |
+0 lines, -67 lines |
0 comments
|
Download
|
|
D |
chrome/install_static/install_details.h
|
View
|
|
1 chunk |
+0 lines, -172 lines |
0 comments
|
Download
|
|
D |
chrome/install_static/install_details.cc
|
View
|
|
1 chunk |
+0 lines, -91 lines |
0 comments
|
Download
|
|
D |
chrome/install_static/install_details_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -151 lines |
0 comments
|
Download
|
|
D |
chrome/install_static/install_modes.h
|
View
|
|
1 chunk |
+0 lines, -82 lines |
0 comments
|
Download
|
|
D |
chrome/install_static/install_modes.cc
|
View
|
|
1 chunk |
+0 lines, -51 lines |
0 comments
|
Download
|
|
D |
chrome/install_static/install_modes_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -105 lines |
0 comments
|
Download
|
|
M |
chrome/install_static/install_util.h
|
View
|
|
9 chunks |
+61 lines, -15 lines |
0 comments
|
Download
|
|
M |
chrome/install_static/install_util.cc
|
View
|
|
14 chunks |
+363 lines, -191 lines |
0 comments
|
Download
|
|
M |
chrome/install_static/install_util_unittest.cc
|
View
|
|
3 chunks |
+103 lines, -211 lines |
0 comments
|
Download
|
|
D |
chrome/install_static/product_install_details.h
|
View
|
|
1 chunk |
+0 lines, -49 lines |
0 comments
|
Download
|
|
D |
chrome/install_static/product_install_details.cc
|
View
|
|
1 chunk |
+0 lines, -148 lines |
0 comments
|
Download
|
|
D |
chrome/install_static/product_install_details_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -354 lines |
0 comments
|
Download
|
|
M |
chrome/nacl/DEPS
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/nacl/nacl_exe_win_64.cc
|
View
|
|
2 chunks |
+0 lines, -6 lines |
0 comments
|
Download
|
|
M |
chrome/test/base/chrome_test_launcher.cc
|
View
|
|
4 chunks |
+0 lines, -16 lines |
0 comments
|
Download
|
|
M |
chrome_elf/DEPS
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome_elf/chrome_elf.def
|
View
|
|
1 chunk |
+2 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome_elf/chrome_elf_main.cc
|
View
|
|
2 chunks |
+0 lines, -11 lines |
0 comments
|
Download
|
|
M |
chrome_elf/chrome_elf_util_unittest.cc
|
View
|
|
3 chunks |
+419 lines, -0 lines |
0 comments
|
Download
|
|
M |
components/nacl/broker/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
Total messages: 6 (2 generated)
|