Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Unified Diff: ui/file_manager/audio_player/elements/repeat_button.html

Issue 2491213002: Make the repeat button accessible by keyboard. (Closed)
Patch Set: Fix duplicated ripple effect. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/audio_player/elements/repeat_button.html
diff --git a/ui/file_manager/audio_player/elements/repeat_button.html b/ui/file_manager/audio_player/elements/repeat_button.html
index c38390cafdf18e56b2bf049a21b1577c1e1c4a4a..5af558ebbba1f4fd33fb403911610e01a27459f3 100644
--- a/ui/file_manager/audio_player/elements/repeat_button.html
+++ b/ui/file_manager/audio_player/elements/repeat_button.html
@@ -4,12 +4,14 @@
-->
<link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">
-<link rel="import" href="chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/foreground/elements/files_toggle_ripple.html">
+<link rel="import" href="chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/foreground/elements/files_icon_button.html">
<dom-module id="repeat-button">
<link rel="import" type="css" href="repeat_button.css">
<template>
- <files-toggle-ripple activated="[[isActive(repeatMode)]]" class$="{{repeatMode}}"></files-toggle-ripple>
+ <files-icon-button active="[[isActive(repeatMode)]]"
+ repeat-mode$="{{repeatMode}}" toggles>
fukino 2016/11/10 08:30:19 What is the intention to change "class$=" to "repe
yamaguchi 2016/11/10 08:43:16 To avoid that keyboard focus indicator disappears
fukino 2016/11/10 09:28:32 I see. Since the repeatMode's refrectToAttribute i
+ </files-icon-button>
</template>
<script src="repeat_button.js"></script>

Powered by Google App Engine
This is Rietveld 408576698