ui/file_manager/audio_player/elements/repeat_button.html - Issue 2491213002: Make the repeat button accessible by keyboard.

Side by Side Diff: ui/file_manager/audio_player/elements/repeat_button.html

Issue 2491213002: Make the repeat button accessible by keyboard. (Closed)

Patch Set: Fix duplicated ripple effect. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« ui/file_manager/audio_player/elements/repeat_button.css ('K') | « ui/file_manager/audio_player/elements/repeat_button.css ('k') | ui/file_manager/integration_tests/file_manager/open_audio_files.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!-- Copyright 2016 The Chromium Authors. All rights reserved.	1 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

2 -- Use of this source code is governed by a BSD-style license that can be	2 -- Use of this source code is governed by a BSD-style license that can be

3 -- found in the LICENSE file.	3 -- found in the LICENSE file.

4 -->	4 -->

5	5

6 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">	6 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">

7 <link rel="import" href="chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/for eground/elements/files_toggle_ripple.html">	7 <link rel="import" href="chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/for eground/elements/files_icon_button.html">

8	8

9 <dom-module id="repeat-button">	9 <dom-module id="repeat-button">

10 <link rel="import" type="css" href="repeat_button.css">	10 <link rel="import" type="css" href="repeat_button.css">

11 <template>	11 <template>

12 <files-toggle-ripple activated="[[isActive(repeatMode)]]" class$="{{repeatMo de}}"></files-toggle-ripple>	12 <files-icon-button active="[[isActive(repeatMode)]]"

	13 repeat-mode$="{{repeatMode}}" toggles>
	fukino 2016/11/10 08:30:19 What is the intention to change "class$=" to "repe What is the intention to change "class$=" to "repeat-mode$="? I guess class$= still works and we won't need to modify tests with it? yamaguchi 2016/11/10 08:43:16 To avoid that keyboard focus indicator disappears Show quoted text On 2016/11/10 08:30:19, fukino wrote: > What is the intention to change "class$=" to "repeat-mode$="? > I guess class$= still works and we won't need to modify tests with it? To avoid that keyboard focus indicator disappears when hitting Enter key on the button. https://codereview.chromium.org/2482063002/#ps40001 When we put the toggle status as a part of class attribute, I found the script will remove the "keyboard-focus" value in class attribute here: https://cs.chromium.org/chromium/src/third_party/catapult/third_party/polymer... which should have been added by files-icon-button: https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/... I am not yet 100% sure if there's a better solution, though. fukino 2016/11/10 09:28:32 I see. Since the repeatMode's refrectToAttribute i Show quoted text On 2016/11/10 08:43:16, yamaguchi wrote: > On 2016/11/10 08:30:19, fukino wrote: > > What is the intention to change "class$=" to "repeat-mode$="? > > I guess class$= still works and we won't need to modify tests with it? > > To avoid that keyboard focus indicator disappears when hitting Enter key on the > button. > https://codereview.chromium.org/2482063002/#ps40001 > > When we put the toggle status as a part of class attribute, I found the script > will remove the "keyboard-focus" value in class attribute here: > https://cs.chromium.org/chromium/src/third_party/catapult/third_party/polymer... > which should have been added by files-icon-button: > https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/... > > I am not yet 100% sure if there's a better solution, though. I see. Since the repeatMode's refrectToAttribute is true, we can set background image without this binding. I left comment in the css file.
	14 </files-icon-button>

13 </template>	15 </template>

14	16

15 <script src="repeat_button.js"></script>	17 <script src="repeat_button.js"></script>

16 </dom-module>	18 </dom-module>

OLD	NEW