Add Refresh{Device,User}Policies methods into AuthPolicyClient

Add Refresh{Device,User}Policies methods into AuthPolicyClient

BUG=656558, 655971
Committed: https://crrev.com/96b23bd9b84ebee3fda633fa9ba640b5ceccb67c
Cr-Commit-Position: refs/heads/master@{#432163}

[Roman Sorokin (ftl), 2016-11-10 13:10:20]

The CQ bit was checked by rsorokin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 13:10:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Roman Sorokin (ftl), 2016-11-10 13:10:52]

rsorokin@chromium.org changed reviewers:
+ hashimoto@chromium.org

[Roman Sorokin (ftl), 2016-11-10 13:10:52]

Hachimoto, please take a look

[Roman Sorokin (ftl), 2016-11-10 13:11:50]

Sorry for the typo :)

[commit-bot: I haz the power, 2016-11-10 13:45:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 13:45:41]

Dry run: This issue passed the CQ dry run.

[hashimoto, 2016-11-10 23:02:19]

https://codereview.chromium.org/2491153003/diff/1/chromeos/dbus/auth_policy_c...
File chromeos/dbus/auth_policy_client.cc (right):

https://codereview.chromium.org/2491153003/diff/1/chromeos/dbus/auth_policy_c...
chromeos/dbus/auth_policy_client.cc:41:
authpolicy::kAuthPolicyRefreshDevicePolicy);
Policies (RefreshDevicePolicies) or Policy (kAuthPolicyRefreshDevicePolicy)?
Please stick to the correct name.

The same goes for the other method.

https://codereview.chromium.org/2491153003/diff/1/chromeos/dbus/auth_policy_c...
chromeos/dbus/auth_policy_client.cc:42: dbus::MessageWriter
writer(&method_call);
This writer looks unneeded.

https://codereview.chromium.org/2491153003/diff/1/chromeos/dbus/auth_policy_c...
chromeos/dbus/auth_policy_client.cc:78: }
nit: Put a blank line between methods.

https://codereview.chromium.org/2491153003/diff/1/chromeos/dbus/auth_policy_c...
chromeos/dbus/auth_policy_client.cc:101: dbus::ObjectProxy* proxy_;
= nullptr;

https://codereview.chromium.org/2491153003/diff/1/chromeos/dbus/auth_policy_c...
File chromeos/dbus/auth_policy_client.h (right):

https://codereview.chromium.org/2491153003/diff/1/chromeos/dbus/auth_policy_c...
chromeos/dbus/auth_policy_client.h:50: const JoinCallback& callback) = 0;
nit: Put blank lines between methods.

https://codereview.chromium.org/2491153003/diff/1/chromeos/dbus/auth_policy_c...
chromeos/dbus/auth_policy_client.h:51: // Refresh{Device,User}Policies fetch GPO
files with policies from Active
Please write a comment for each method.
If you want to save key strokes, you can say something like "similar to
RefreshDevicePolicies" to avoid duplicates.

[Roman Sorokin (ftl), 2016-11-14 14:10:18]

hashimoto@, please take another look

https://codereview.chromium.org/2491153003/diff/1/chromeos/dbus/auth_policy_c...
File chromeos/dbus/auth_policy_client.cc (right):

https://codereview.chromium.org/2491153003/diff/1/chromeos/dbus/auth_policy_c...
chromeos/dbus/auth_policy_client.cc:41:
authpolicy::kAuthPolicyRefreshDevicePolicy);
On 2016/11/10 23:02:19, hashimoto wrote:
> Policies (RefreshDevicePolicies) or Policy (kAuthPolicyRefreshDevicePolicy)?
> Please stick to the correct name.
> 
> The same goes for the other method.

Done.

https://codereview.chromium.org/2491153003/diff/1/chromeos/dbus/auth_policy_c...
chromeos/dbus/auth_policy_client.cc:42: dbus::MessageWriter
writer(&method_call);
On 2016/11/10 23:02:19, hashimoto wrote:
> This writer looks unneeded.

Done.

https://codereview.chromium.org/2491153003/diff/1/chromeos/dbus/auth_policy_c...
chromeos/dbus/auth_policy_client.cc:78: }
On 2016/11/10 23:02:19, hashimoto wrote:
> nit: Put a blank line between methods.

Done.

https://codereview.chromium.org/2491153003/diff/1/chromeos/dbus/auth_policy_c...
chromeos/dbus/auth_policy_client.cc:101: dbus::ObjectProxy* proxy_;
On 2016/11/10 23:02:19, hashimoto wrote:
> = nullptr;

Done.

https://codereview.chromium.org/2491153003/diff/1/chromeos/dbus/auth_policy_c...
File chromeos/dbus/auth_policy_client.h (right):

https://codereview.chromium.org/2491153003/diff/1/chromeos/dbus/auth_policy_c...
chromeos/dbus/auth_policy_client.h:50: const JoinCallback& callback) = 0;
On 2016/11/10 23:02:19, hashimoto wrote:
> nit: Put blank lines between methods.

Done.

https://codereview.chromium.org/2491153003/diff/1/chromeos/dbus/auth_policy_c...
chromeos/dbus/auth_policy_client.h:51: // Refresh{Device,User}Policies fetch GPO
files with policies from Active
On 2016/11/10 23:02:19, hashimoto wrote:
> Please write a comment for each method.
> If you want to save key strokes, you can say something like "similar to
> RefreshDevicePolicies" to avoid duplicates.

Done.

[hashimoto, 2016-11-14 22:00:46]

lgtm

[Roman Sorokin (ftl), 2016-11-15 10:06:16]

The CQ bit was checked by rsorokin@chromium.org

[commit-bot: I haz the power, 2016-11-15 10:06:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 11:11:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-15 11:16:18]

Description was changed from

==========
Add Refresh{Device,User}Policies methods into AuthPolicyClient

BUG=656558,655971
==========

to

==========
Add Refresh{Device,User}Policies methods into AuthPolicyClient

BUG=656558,655971

Committed: https://crrev.com/96b23bd9b84ebee3fda633fa9ba640b5ceccb67c
Cr-Commit-Position: refs/heads/master@{#432163}
==========

[commit-bot: I haz the power, 2016-11-15 11:16:18]

Patchset 2 (id:??) landed as
https://crrev.com/96b23bd9b84ebee3fda633fa9ba640b5ceccb67c
Cr-Commit-Position: refs/heads/master@{#432163}