Add Refresh{Device,User}Policies methods into AuthPolicyClient

chromeos/dbus/auth_policy_client.h

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_DBUS_AUTH_POLICY_CLIENT_H_
 #define CHROMEOS_DBUS_AUTH_POLICY_CLIENT_H_
 
 #include <string>
 
 #include "base/callback.h"
@@ skipping 11 matching lines @@
 }
 
 namespace chromeos {
 
 // AuthPolicyClient is used to communicate with the org.chromium.AuthPolicy
 // sevice. All method should be called from the origin thread (UI thread) which
 // initializes the DBusThreadManager instance.
 class CHROMEOS_EXPORT AuthPolicyClient : public DBusClient {
  public:
   using JoinCallback = base::Callback<void(int error_code)>;
+  using RefreshPoliciesCallback = base::Callback<void(bool success)>;
 
   ~AuthPolicyClient() override;
 
   // Factory function, creates a new instance and returns ownership.
   // For normal usage, access the singleton via DBusThreadManager::Get().
   static AuthPolicyClient* Create();
 
-  // TODO(rsorokin): Write more descriptive comment.
-  // Calls JoinADDomain. Uses |machine_name| to join it to the domain. |user|,
-  // |password_fd| are credentials of the AD user which have right to join the
-  // domain. |password_fd| is a file descriptor password is read from.
-  // The caller should close it after the call.
+  // Calls JoinADDomain. It runs "net ads join ..." which joins machine to
+  // Active directory domain.
+  // |machine_name| is a name for a local machine. |user|,
+  // |password_fd| are credentials of the Active directory account which has
+  // right to join the machine to the domain. |password_fd| is a file descriptor
+  // password is read from. The caller should close it after the call.
   // |callback| is called after the method call succeeds.
   virtual void JoinAdDomain(const std::string& machine_name,
                             const std::string& user,
                             int password_fd,
                             const JoinCallback& callback) = 0;

[hashimoto, 2016/11/10 23:02:19]

nit: Put blank lines between methods.

[Roman Sorokin (ftl), 2016/11/14 14:10:18]

Done.

+  // Refresh{Device,User}Policies fetch GPO files with policies from Active

[hashimoto, 2016/11/10 23:02:19]

Please write a comment for each method.
If you want to save key strokes, you can say something like "similar to
RefreshDevicePolicies" to avoid duplicates.

[Roman Sorokin (ftl), 2016/11/14 14:10:18]

Done.

+  // directory server, parse it, encode it into protobuf and send to
+  // SessionManager. Callback is called after that.
+  // Calls RefreshDevicePolicies - handle policies for the device.
+  virtual void RefreshDevicePolicies(
+      const RefreshPoliciesCallback& callback) = 0;
+  // Calls RefreshUserPolicies - handle policies for the user specified by
+  // |account_id|.
+  virtual void RefreshUserPolicies(const std::string& account_id,
+                                   const RefreshPoliciesCallback& callback) = 0;
 
  protected:
   // Create() should be used instead.
   AuthPolicyClient();
 
  private:
   DISALLOW_COPY_AND_ASSIGN(AuthPolicyClient);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_DBUS_AUTH_POLICY_CLIENT_H_