Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2491043004: Updating docs for perf sheriffing rotation. (Closed)

Created:
4 years, 1 month ago by eyaich1
Modified:
4 years, 1 month ago
Reviewers:
sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updating docs for perf sheriffing rotation. BUG=chromium:663372 Committed: https://crrev.com/c63bcf3a61dcd82f4541dd7b8703c13a51717182 Cr-Commit-Position: refs/heads/master@{#431271}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removing all caps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tools/perf/docs/perf_bot_sheriffing.md View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
eyaich1
4 years, 1 month ago (2016-11-10 15:27:35 UTC) #2
sullivan
lgtm Thanks! https://codereview.chromium.org/2491043004/diff/1/tools/perf/docs/perf_bot_sheriffing.md File tools/perf/docs/perf_bot_sheriffing.md (right): https://codereview.chromium.org/2491043004/diff/1/tools/perf/docs/perf_bot_sheriffing.md#newcode263 tools/perf/docs/perf_bot_sheriffing.md:263: Non-telemetry tests are configured in [chromium.perf.json](https://code.google.com/p/chromium/codesearch#chromium/src/testing/buildbot/chromium.perf.json) BUT ...
4 years, 1 month ago (2016-11-10 15:29:12 UTC) #3
eyaich1
https://codereview.chromium.org/2491043004/diff/1/tools/perf/docs/perf_bot_sheriffing.md File tools/perf/docs/perf_bot_sheriffing.md (right): https://codereview.chromium.org/2491043004/diff/1/tools/perf/docs/perf_bot_sheriffing.md#newcode263 tools/perf/docs/perf_bot_sheriffing.md:263: Non-telemetry tests are configured in [chromium.perf.json](https://code.google.com/p/chromium/codesearch#chromium/src/testing/buildbot/chromium.perf.json) BUT DO NOT ...
4 years, 1 month ago (2016-11-10 15:36:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491043004/20001
4 years, 1 month ago (2016-11-10 15:36:51 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-10 16:28:27 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 16:34:24 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c63bcf3a61dcd82f4541dd7b8703c13a51717182
Cr-Commit-Position: refs/heads/master@{#431271}

Powered by Google App Engine
This is Rietveld 408576698