Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 # Perf Bot Sheriffing | 1 # Perf Bot Sheriffing |
| 2 | 2 |
| 3 The perf bot sheriff is responsible for keeping the bots on the chromium.perf | 3 The perf bot sheriff is responsible for keeping the bots on the chromium.perf |
| 4 waterfall up and running, and triaging performance test failures and flakes. | 4 waterfall up and running, and triaging performance test failures and flakes. |
| 5 | 5 |
| 6 **[Rotation calendar](https://calendar.google.com/calendar/embed?src=google.com_ 2fpmo740pd1unrui9d7cgpbg2k%40group.calendar.google.com)** | 6 **[Rotation calendar](https://calendar.google.com/calendar/embed?src=google.com_ 2fpmo740pd1unrui9d7cgpbg2k%40group.calendar.google.com)** |
| 7 | 7 |
| 8 ## Key Responsibilities | 8 ## Key Responsibilities |
| 9 | 9 |
| 10 * [Handle Device and Bot Failures](#Handle-Device-and-Bot-Failures) | 10 * [Handle Device and Bot Failures](#Handle-Device-and-Bot-Failures) |
| (...skipping 242 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 253 some [examples](https://code.google.com/p/chromium/codesearch#search/&q=ShouldDi sable%20GetDeviceTypeName%20lang:py&sq=package:chromium&type=cs) | 253 some [examples](https://code.google.com/p/chromium/codesearch#search/&q=ShouldDi sable%20GetDeviceTypeName%20lang:py&sq=package:chromium&type=cs) |
| 254 of this. The type name of the failing device can be found by searching for the | 254 of this. The type name of the failing device can be found by searching for the |
| 255 value of `ro.product.model` under the `provision_devices` step of the failing | 255 value of `ro.product.model` under the `provision_devices` step of the failing |
| 256 bot. | 256 bot. |
| 257 | 257 |
| 258 Disabling CLs can be TBR-ed to anyone in [tools/perf/OWNERS](https://code.google .com/p/chromium/codesearch#chromium/src/tools/perf/OWNERS), | 258 Disabling CLs can be TBR-ed to anyone in [tools/perf/OWNERS](https://code.google .com/p/chromium/codesearch#chromium/src/tools/perf/OWNERS), |
| 259 but please do **not** submit with NOTRY=true. | 259 but please do **not** submit with NOTRY=true. |
| 260 | 260 |
| 261 ### Disabling Other Tests | 261 ### Disabling Other Tests |
| 262 | 262 |
| 263 Non-telemetry tests are configured in [chromium.perf.json](https://code.google.c om/p/chromium/codesearch#chromium/src/testing/buildbot/chromium.perf.json). | 263 Non-telemetry tests are configured in [chromium.perf.json](https://code.google.c om/p/chromium/codesearch#chromium/src/testing/buildbot/chromium.perf.json) BUT D O NOT MANUALLY EDIT THIS FILE. |
|
sullivan
2016/11/10 15:29:12
You can use bold instead of all caps: **But do not
eyaich1
2016/11/10 15:36:26
Done.
| |
| 264 Update tools/perf/generate_perf_json.py to disable the test and rerun script to | |
| 265 generate the new chromium.perf.json file. | |
| 264 You can TBR any of the per-file OWNERS, but please do **not** submit with | 266 You can TBR any of the per-file OWNERS, but please do **not** submit with |
| 265 NOTRY=true. | 267 NOTRY=true. |
| 266 | 268 |
| 267 ## Follow up on failures | 269 ## Follow up on failures |
| 268 | 270 |
| 269 **[Pri-0 bugs](https://bugs.chromium.org/p/chromium/issues/list?can=2&q=label%3A Performance-Sheriff-BotHealth+label%3APri-0)** | 271 **[Pri-0 bugs](https://bugs.chromium.org/p/chromium/issues/list?can=2&q=label%3A Performance-Sheriff-BotHealth+label%3APri-0)** |
| 270 should have an owner or contact on speed infra team and be worked on as top | 272 should have an owner or contact on speed infra team and be worked on as top |
| 271 priority. Pri-0 generally implies an entire waterfall is down. | 273 priority. Pri-0 generally implies an entire waterfall is down. |
| 272 | 274 |
| 273 **[Pri-1 bugs](https://bugs.chromium.org/p/chromium/issues/list?can=2&q=label%3A Performance-Sheriff-BotHealth+label%3APri-1)** | 275 **[Pri-1 bugs](https://bugs.chromium.org/p/chromium/issues/list?can=2&q=label%3A Performance-Sheriff-BotHealth+label%3APri-1)** |
| 274 should be pinged daily, and checked to make sure someone is following up. Pri-1 | 276 should be pinged daily, and checked to make sure someone is following up. Pri-1 |
| 275 bugs are for a red test (not yet disabled), purple bot, or failing device. Here | 277 bugs are for a red test (not yet disabled), purple bot, or failing device. Here |
| 276 is the [list of Pri-1 bugs that have not been pinged today](https://bugs.chromiu m.org/p/chromium/issues/list?can=2&q=label:Performance-Sheriff-BotHealth%20label :Pri-1%20modified-before:today-1&sort=modified). | 278 is the [list of Pri-1 bugs that have not been pinged today](https://bugs.chromiu m.org/p/chromium/issues/list?can=2&q=label:Performance-Sheriff-BotHealth%20label :Pri-1%20modified-before:today-1&sort=modified). |
| 277 | 279 |
| 278 **[Pri-2 bugs](https://bugs.chromium.org/p/chromium/issues/list?can=2&q=label%3A Performance-Sheriff-BotHealth+label%3APri-2)** | 280 **[Pri-2 bugs](https://bugs.chromium.org/p/chromium/issues/list?can=2&q=label%3A Performance-Sheriff-BotHealth+label%3APri-2)** |
| 279 are for disabled tests. These should be pinged weekly, and work towards fixing | 281 are for disabled tests. These should be pinged weekly, and work towards fixing |
| 280 should be ongoing when the sheriff is not working on a Pri-1 issue. Here is the | 282 should be ongoing when the sheriff is not working on a Pri-1 issue. Here is the |
| 281 [list of Pri-2 bugs that have not been pinged in a week](https://bugs.chromium.o rg/p/chromium/issues/list?can=2&q=label:Performance-Sheriff-BotHealth%20label:Pr i-2%20modified-before:today-7&sort=modified). | 283 [list of Pri-2 bugs that have not been pinged in a week](https://bugs.chromium.o rg/p/chromium/issues/list?can=2&q=label:Performance-Sheriff-BotHealth%20label:Pr i-2%20modified-before:today-7&sort=modified). |
| 282 | 284 |
| 283 <!-- Unresolved issues: | 285 <!-- Unresolved issues: |
| 284 1. Do perf sheriffs watch the bisect waterfall? | 286 1. Do perf sheriffs watch the bisect waterfall? |
| 285 2. Do perf sheriffs watch the internal clank waterfall? | 287 2. Do perf sheriffs watch the internal clank waterfall? |
| 286 --> | 288 --> |
| OLD | NEW |