Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2490973002: [turbofan] Fix -Wsign-compare warnings. (Closed)

Created:
4 years, 1 month ago by ulan
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer, ahaas
CC:
Michael Achenbach, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix -Wsign-compare warnings. BUG=v8:5614 Committed: https://crrev.com/4d5f58799cad22e5e7224c08092d9ddd36773fb1 Cr-Commit-Position: refs/heads/master@{#40879}

Patch Set 1 : 1 #

Patch Set 2 : 1 #

Patch Set 3 : fix dcheck #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -43 lines) Patch
M src/compiler/effect-control-linearizer.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M src/compiler/escape-analysis.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/int64-lowering.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/simd-scalar-lowering.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simd-scalar-lowering.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M test/cctest/asmjs/test-asm-typer.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-load-store.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 7 chunks +31 lines, -25 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
ulan
ptal
4 years, 1 month ago (2016-11-09 16:24:47 UTC) #4
Benedikt Meurer
Nice, thanks Ulan. LGTM
4 years, 1 month ago (2016-11-09 19:50:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2490973002/80001
4 years, 1 month ago (2016-11-10 09:36:03 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/28212)
4 years, 1 month ago (2016-11-10 09:39:37 UTC) #9
ulan
Andreas, could you please take a look at asmjs test as an owner?
4 years, 1 month ago (2016-11-10 09:42:50 UTC) #11
ahaas
lgtm
4 years, 1 month ago (2016-11-10 09:49:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2490973002/80001
4 years, 1 month ago (2016-11-10 09:54:33 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:80001)
4 years, 1 month ago (2016-11-10 10:02:53 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:28:25 UTC) #17
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/4d5f58799cad22e5e7224c08092d9ddd36773fb1
Cr-Commit-Position: refs/heads/master@{#40879}

Powered by Google App Engine
This is Rietveld 408576698