Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: test/cctest/compiler/test-run-machops.cc

Issue 2490973002: [turbofan] Fix -Wsign-compare warnings. (Closed)
Patch Set: fix dcheck Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/compiler/test-run-load-store.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/compiler/test-run-machops.cc
diff --git a/test/cctest/compiler/test-run-machops.cc b/test/cctest/compiler/test-run-machops.cc
index 1beb1ad56c64cf1227368230bab2747fa2c73dec..ccf4b847697c49b9a1dd4c229b5b3a6c318a1f2a 100644
--- a/test/cctest/compiler/test-run-machops.cc
+++ b/test/cctest/compiler/test-run-machops.cc
@@ -4171,11 +4171,12 @@ TEST(RunInt32PairAddUseOnlyHighWord) {
FOR_UINT64_INPUTS(i) {
FOR_UINT64_INPUTS(j) {
- CHECK_EQ(static_cast<uint32_t>((*i + *j) >> 32),
- m.Call(static_cast<uint32_t>(*i & 0xffffffff),
- static_cast<uint32_t>(*i >> 32),
- static_cast<uint32_t>(*j & 0xffffffff),
- static_cast<uint32_t>(*j >> 32)));
+ CHECK_EQ(
+ static_cast<uint32_t>((*i + *j) >> 32),
+ static_cast<uint32_t>(m.Call(static_cast<uint32_t>(*i & 0xffffffff),
+ static_cast<uint32_t>(*i >> 32),
+ static_cast<uint32_t>(*j & 0xffffffff),
+ static_cast<uint32_t>(*j >> 32))));
}
}
}
@@ -4253,11 +4254,12 @@ TEST(RunInt32PairSubUseOnlyHighWord) {
FOR_UINT64_INPUTS(i) {
FOR_UINT64_INPUTS(j) {
- CHECK_EQ(static_cast<uint32_t>((*i - *j) >> 32),
- m.Call(static_cast<uint32_t>(*i & 0xffffffff),
- static_cast<uint32_t>(*i >> 32),
- static_cast<uint32_t>(*j & 0xffffffff),
- static_cast<uint32_t>(*j >> 32)));
+ CHECK_EQ(
+ static_cast<uint32_t>((*i - *j) >> 32),
+ static_cast<uint32_t>(m.Call(static_cast<uint32_t>(*i & 0xffffffff),
+ static_cast<uint32_t>(*i >> 32),
+ static_cast<uint32_t>(*j & 0xffffffff),
+ static_cast<uint32_t>(*j >> 32))));
}
}
}
@@ -4335,11 +4337,12 @@ TEST(RunInt32PairMulUseOnlyHighWord) {
FOR_UINT64_INPUTS(i) {
FOR_UINT64_INPUTS(j) {
- CHECK_EQ(static_cast<uint32_t>((*i * *j) >> 32),
- m.Call(static_cast<uint32_t>(*i & 0xffffffff),
- static_cast<uint32_t>(*i >> 32),
- static_cast<uint32_t>(*j & 0xffffffff),
- static_cast<uint32_t>(*j >> 32)));
+ CHECK_EQ(
+ static_cast<uint32_t>((*i * *j) >> 32),
+ static_cast<uint32_t>(m.Call(static_cast<uint32_t>(*i & 0xffffffff),
+ static_cast<uint32_t>(*i >> 32),
+ static_cast<uint32_t>(*j & 0xffffffff),
+ static_cast<uint32_t>(*j >> 32))));
}
}
}
@@ -4414,9 +4417,10 @@ TEST(RunWord32PairShlUseOnlyHighWord) {
FOR_UINT64_INPUTS(i) {
for (uint32_t j = 0; j < 64; j++) {
- CHECK_EQ(static_cast<uint32_t>((*i << j) >> 32),
- m.Call(static_cast<uint32_t>(*i & 0xffffffff),
- static_cast<uint32_t>(*i >> 32), j));
+ CHECK_EQ(
+ static_cast<uint32_t>((*i << j) >> 32),
+ static_cast<uint32_t>(m.Call(static_cast<uint32_t>(*i & 0xffffffff),
+ static_cast<uint32_t>(*i >> 32), j)));
}
}
}
@@ -4487,9 +4491,10 @@ TEST(RunWord32PairShrUseOnlyHighWord) {
FOR_UINT64_INPUTS(i) {
for (uint32_t j = 0; j < 64; j++) {
- CHECK_EQ(static_cast<uint32_t>((*i >> j) >> 32),
- m.Call(static_cast<uint32_t>(*i & 0xffffffff),
- static_cast<uint32_t>(*i >> 32), j));
+ CHECK_EQ(
+ static_cast<uint32_t>((*i >> j) >> 32),
+ static_cast<uint32_t>(m.Call(static_cast<uint32_t>(*i & 0xffffffff),
+ static_cast<uint32_t>(*i >> 32), j)));
}
}
}
@@ -4514,7 +4519,7 @@ TEST(RunWord32PairSar) {
for (uint32_t j = 0; j < 64; j++) {
m.Call(static_cast<uint32_t>(*i & 0xffffffff),
static_cast<uint32_t>(*i >> 32), j);
- CHECK_EQ(*i >> j, ToInt64(low, high));
+ CHECK_EQ(*i >> j, static_cast<int64_t>(ToInt64(low, high)));
}
}
}
@@ -4528,9 +4533,10 @@ TEST(RunWord32PairSarUseOnlyHighWord) {
FOR_INT64_INPUTS(i) {
for (uint32_t j = 0; j < 64; j++) {
- CHECK_EQ(static_cast<uint32_t>((*i >> j) >> 32),
- m.Call(static_cast<uint32_t>(*i & 0xffffffff),
- static_cast<uint32_t>(*i >> 32), j));
+ CHECK_EQ(
+ static_cast<uint32_t>((*i >> j) >> 32),
+ static_cast<uint32_t>(m.Call(static_cast<uint32_t>(*i & 0xffffffff),
+ static_cast<uint32_t>(*i >> 32), j)));
}
}
}
« no previous file with comments | « test/cctest/compiler/test-run-load-store.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698