Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Unified Diff: tools/external-reference-check.py

Issue 2490783004: [serializer] small fixes for blink snapshot. (Closed)
Patch Set: rebase and fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-serialize.cc ('k') | tools/presubmit.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/external-reference-check.py
diff --git a/tools/external-reference-check.py b/tools/external-reference-check.py
deleted file mode 100644
index be01dec1d07a7ca16e2cf006226303e15f883e48..0000000000000000000000000000000000000000
--- a/tools/external-reference-check.py
+++ /dev/null
@@ -1,44 +0,0 @@
-#!/usr/bin/env python
-# Copyright 2014 the V8 project authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-import re
-import os
-import sys
-
-DECLARE_FILE = "src/assembler.h"
-REGISTER_FILE = "src/external-reference-table.cc"
-DECLARE_RE = re.compile("\s*static ExternalReference ([^(]+)\(")
-REGISTER_RE = re.compile("\s*Add\(ExternalReference::([^(]+)\(")
-
-WORKSPACE = os.path.abspath(os.path.join(os.path.dirname(sys.argv[0]), ".."))
-
-# Ignore those.
-BLACKLISTED = [
- "fixed_typed_array_base_data_offset",
- "page_flags",
- "math_exp_constants",
- "math_exp_log_table",
- "ForDeoptEntry",
-]
-
-def Find(filename, re):
- references = []
- with open(filename, "r") as f:
- for line in f:
- match = re.match(line)
- if match:
- references.append(match.group(1))
- return references
-
-def Main():
- declarations = Find(DECLARE_FILE, DECLARE_RE)
- registrations = Find(REGISTER_FILE, REGISTER_RE)
- difference = list(set(declarations) - set(registrations) - set(BLACKLISTED))
- for reference in difference:
- print("Declared but not registered: ExternalReference::%s" % reference)
- return len(difference) > 0
-
-if __name__ == "__main__":
- sys.exit(Main())
« no previous file with comments | « test/cctest/test-serialize.cc ('k') | tools/presubmit.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698