Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: tools/presubmit.py

Issue 2490783004: [serializer] small fixes for blink snapshot. (Closed)
Patch Set: rebase and fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/external-reference-check.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/presubmit.py
diff --git a/tools/presubmit.py b/tools/presubmit.py
index 3be9caf0613bbed3ad27de751f6e1d8413b73c0c..f9ae2bdea465846fe8212d9bd568844ca3de9f57 100755
--- a/tools/presubmit.py
+++ b/tools/presubmit.py
@@ -396,13 +396,6 @@ class SourceProcessor(SourceFileProcessor):
print "Total violating files: %s" % violations
return success
-
-def CheckExternalReferenceRegistration(workspace):
- code = subprocess.call(
- [sys.executable, join(workspace, "tools", "external-reference-check.py")])
- return code == 0
-
-
def _CheckStatusFileForDuplicateKeys(filepath):
comma_space_bracket = re.compile(", *]")
lines = []
@@ -503,7 +496,6 @@ def Main():
print "Running copyright header, trailing whitespaces and " \
"two empty lines between declarations check..."
success &= SourceProcessor().Run(workspace)
- success &= CheckExternalReferenceRegistration(workspace)
success &= CheckStatusFiles(workspace)
if success:
return 0
« no previous file with comments | « tools/external-reference-check.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698