Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2490473004: [DevTools] Roll third_party/inspector_protocol to e23134c5aa6131e5a3a3afbefce255becce3a3bd. (Closed)

Created:
4 years, 1 month ago by dgozman
Modified:
4 years, 1 month ago
Reviewers:
kozy
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Roll third_party/inspector_protocol to e23134c5aa6131e5a3a3afbefce255becce3a3bd. This includes: - [inspector_protocol] Allow custom json parser. - [inspector_protocol] Allow overriding specific config values. - [inspector_protocol] Fix NoneType error when parsing config_values. BUG=635953 Committed: https://crrev.com/8bd45cc451e96d464522185ef1e946f094442f4b Cr-Commit-Position: refs/heads/master@{#431123}

Patch Set 1 #

Total comments: 1

Patch Set 2 : roll #

Patch Set 3 : roll further #

Patch Set 4 : parser test #

Patch Set 5 : roll further #

Patch Set 6 : ui_devtools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -88 lines) Patch
M components/ui_devtools/BUILD.gn View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M components/ui_devtools/devtools_client.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M components/ui_devtools/inspector_protocol_config.json View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
D components/ui_devtools/protocol_platform.h View 1 2 3 4 5 1 chunk +0 lines, -21 lines 0 comments Download
M components/ui_devtools/string_util.h View 1 2 3 4 5 2 chunks +1 line, -2 lines 0 comments Download
M components/ui_devtools/string_util.cc View 1 2 3 4 5 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/BUILD.gn View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorSession.cpp View 2 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ProtocolParserTest.cpp View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/inspector/ProtocolPlatform.h View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/V8InspectorString.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/V8InspectorString.cpp View 1 chunk +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/inspector_protocol_config.json View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/inspector_protocol/CodeGenerator.py View 1 2 3 4 4 chunks +8 lines, -1 line 0 comments Download
M third_party/inspector_protocol/README.chromium View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/inspector_protocol/inspector_protocol.gni View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/inspector_protocol/lib/Array_h.template View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/inspector_protocol/lib/DispatcherBase_cpp.template View 1 chunk +1 line, -1 line 0 comments Download
M third_party/inspector_protocol/lib/Forward_h.template View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/inspector_protocol/lib/Object_cpp.template View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/inspector_protocol/lib/Parser_cpp.template View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/inspector_protocol/lib/Parser_h.template View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/inspector_protocol/lib/Values_h.template View 8 chunks +11 lines, -11 lines 0 comments Download
M third_party/inspector_protocol/templates/TypeBuilder_cpp.template View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 29 (18 generated)
dgozman
Could you please take a look?
4 years, 1 month ago (2016-11-08 21:28:13 UTC) #2
kozy
lgtm https://codereview.chromium.org/2490473004/diff/1/third_party/inspector_protocol/CodeGenerator.py File third_party/inspector_protocol/CodeGenerator.py (right): https://codereview.chromium.org/2490473004/diff/1/third_party/inspector_protocol/CodeGenerator.py#newcode290 third_party/inspector_protocol/CodeGenerator.py:290: "create_type": "protocol::Array<%s>::create()" % type["raw_type"], Please just remove this.
4 years, 1 month ago (2016-11-08 21:40:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2490473004/20001
4 years, 1 month ago (2016-11-08 22:06:05 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/231411)
4 years, 1 month ago (2016-11-08 22:24:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2490473004/60001
4 years, 1 month ago (2016-11-08 23:31:08 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/231598)
4 years, 1 month ago (2016-11-08 23:48:53 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2490473004/80001
4 years, 1 month ago (2016-11-09 01:13:25 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/231577) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 1 month ago (2016-11-09 01:29:43 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2490473004/100001
4 years, 1 month ago (2016-11-09 22:59:55 UTC) #25
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 1 month ago (2016-11-10 01:06:41 UTC) #27
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 01:22:19 UTC) #29
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/8bd45cc451e96d464522185ef1e946f094442f4b
Cr-Commit-Position: refs/heads/master@{#431123}

Powered by Google App Engine
This is Rietveld 408576698