Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Unified Diff: build/common.gypi

Issue 249073003: Fix unresolved shared library dependency on binutils 2.23. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 52a91e30392da630a489f467da72539eb8f1407c..33e834212d8484c86c238cead065d84adeb2293a 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -3893,7 +3893,7 @@
'-B<!(cd <(DEPTH) && pwd -P)/<(binutils_dir)',
],
}],
- ['binutils_version>=224', {
+ ['binutils_version>=223', {
dshwang 2014/04/23 15:23:45 I'm not sure if 222 works also. Anyway, 223 work w
Lei Zhang 2014/04/23 18:14:09 I'm worried older 2.23 releases didn't have new-dt
dshwang 2014/04/23 20:05:23 Thank you for review. I think omitting --disable-n
dshwang 2014/04/23 20:14:53 Ah, my previous comment does not make sense. The
# Newer binutils don't set DT_RPATH unless you disable "new" dtags
# and the new DT_RUNPATH doesn't work without --no-as-needed flag.
# FIXME(mithro): Figure out the --as-needed/--no-as-needed flags
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698